[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31992: [SPARK-34898][CORE] We should send SparkListenerExecutorMetricsUpdateEventLog of `driver` appropriately

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #31992:
URL: https://github.com/apache/spark/pull/31992#discussion_r603734003



##########
File path: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala
##########
@@ -249,6 +249,9 @@ private[spark] class EventLoggingListener(
   }
 
   override def onExecutorMetricsUpdate(event: SparkListenerExecutorMetricsUpdate): Unit = {
+    if (event.execId == SparkContext.DRIVER_IDENTIFIER) {
+      logEvent(event)
+    }

Review comment:
       > Do this only when `shouldLogStageExecutorMetrics` is enabled ?
   
   I don't thinks it should be controlled by `shouldLogStageExecutorMetrics `. since driver's metrics is not related to stage  executor.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org