You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (Created) (JIRA)" <ji...@apache.org> on 2011/10/10 10:32:30 UTC
[jira] [Created] (CASSANDRA-3338) Uncompressed sizes are used to
estimate space for compaction of compressed sstables
Uncompressed sizes are used to estimate space for compaction of compressed sstables
-----------------------------------------------------------------------------------
Key: CASSANDRA-3338
URL: https://issues.apache.org/jira/browse/CASSANDRA-3338
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.0.0
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
We are using the uncompressed data size when estimating if we have enough to compact sstables. This means we can easily refuse compaction when there is clearly enough room to compact.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3338) Uncompressed sizes are used to
estimate space for compaction of compressed sstables
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-3338:
----------------------------------------
Attachment: 3338.patch
> Uncompressed sizes are used to estimate space for compaction of compressed sstables
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-3338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Labels: compression
> Attachments: 3338.patch
>
>
> We are using the uncompressed data size when estimating if we have enough to compact sstables. This means we can easily refuse compaction when there is clearly enough room to compact.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3338) Uncompressed sizes are used to
estimate space for compaction of compressed sstables
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124105#comment-13124105 ]
Jonathan Ellis commented on CASSANDRA-3338:
-------------------------------------------
+1
> Uncompressed sizes are used to estimate space for compaction of compressed sstables
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-3338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Labels: compression
> Attachments: 3338-v2.patch, 3338.patch
>
>
> We are using the uncompressed data size when estimating if we have enough to compact sstables. This means we can easily refuse compaction when there is clearly enough room to compact.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3338) Uncompressed sizes are used to
estimate space for compaction of compressed sstables
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-3338:
----------------------------------------
Attachment: 3338-v2.patch
Actually renaming length() to uncompressedLength() proved to be a good idea, as I had missed quite a bunch of places where the onDiskLength should be used. Attached v2.
> Uncompressed sizes are used to estimate space for compaction of compressed sstables
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-3338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Labels: compression
> Attachments: 3338-v2.patch, 3338.patch
>
>
> We are using the uncompressed data size when estimating if we have enough to compact sstables. This means we can easily refuse compaction when there is clearly enough room to compact.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3338) Uncompressed sizes are used to
estimate space for compaction of compressed sstables
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124059#comment-13124059 ]
Jonathan Ellis commented on CASSANDRA-3338:
-------------------------------------------
maybe we should rename .length() to uncompressedLength() as well?
otherwise +1
> Uncompressed sizes are used to estimate space for compaction of compressed sstables
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-3338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3338
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Labels: compression
> Attachments: 3338.patch
>
>
> We are using the uncompressed data size when estimating if we have enough to compact sstables. This means we can easily refuse compaction when there is clearly enough room to compact.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira