You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/05/21 04:35:59 UTC

[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #2620: minor refactoring in MicroBatches class to prep for Spark3 streaming change

RussellSpitzer commented on a change in pull request #2620:
URL: https://github.com/apache/iceberg/pull/2620#discussion_r636628748



##########
File path: core/src/main/java/org/apache/iceberg/MicroBatches.java
##########
@@ -177,11 +177,11 @@ public MicroBatch generate(int startFileIndex, long targetSizeInBytes, boolean i
      * @param startFileIndex A startFileIndex used to skip processed files.
      * @param targetSizeInBytes Used to control the size of MicroBatch, the processed file bytes must be smaller than
      *                         this size.
-     * @param isStarting Used to check where all the data file should be processed, or only added files.
+     * @param scanAllFiles Used to check where all the data file should be processed, or only added files.

Review comment:
       Typo from before : where -. whether 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org