You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "ilya musayev (JIRA)" <ji...@apache.org> on 2012/10/15 22:15:02 UTC
[jira] [Created] (CLOUDSTACK-351) cloud-set-guest-password.in -
include double quotes for variable check when using -n in bash
ilya musayev created CLOUDSTACK-351:
---------------------------------------
Summary: cloud-set-guest-password.in - include double quotes for variable check when using -n in bash
Key: CLOUDSTACK-351
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-351
Project: CloudStack
Issue Type: Bug
Components: Usage
Affects Versions: 4.0.0
Environment: RHEL/CENTOS 5.x/6.x and CS 3.x+/4.x+
Reporter: ilya musayev
Priority: Minor
Fix For: 4.0.0
include double quotes for variable check when using -n in bash - fixes one of issue when variable is present but not seen by bash
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
RE: [jira] [Commented] (CLOUDSTACK-351) cloud-set-guest-password.in
- include double quotes for variable check when using -n in bash
Posted by "Musayev, Ilya" <im...@webmd.net>.
I don’t think anyone committed it - I posted it an hour ago.
-----Original Message-----
From: David Nalley (JIRA) [mailto:jira@apache.org]
Sent: Monday, October 15, 2012 4:29 PM
To: cloudstack-dev@incubator.apache.org
Subject: [jira] [Commented] (CLOUDSTACK-351) cloud-set-guest-password.in - include double quotes for variable check when using -n in bash
[ https://issues.apache.org/jira/browse/CLOUDSTACK-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476405#comment-13476405 ]
David Nalley commented on CLOUDSTACK-351:
-----------------------------------------
Ilya: Has someone committed this code into the repo?
> cloud-set-guest-password.in - include double quotes for variable check
> when using -n in bash
> ----------------------------------------------------------------------
> ----------------------
>
> Key: CLOUDSTACK-351
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-351
> Project: CloudStack
> Issue Type: Bug
> Components: Usage
> Affects Versions: 4.0.0
> Environment: RHEL/CENTOS 5.x/6.x and CS 3.x+/4.x+
> Reporter: ilya musayev
> Priority: Minor
> Labels: patch
> Fix For: 4.0.0
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> include double quotes for variable check when using -n in bash - fixes
> one of issue when variable is present but not seen by bash
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CLOUDSTACK-351) cloud-set-guest-password.in -
include double quotes for variable check when using -n in bash
Posted by "Rohit Yadav (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476761#comment-13476761 ]
Rohit Yadav commented on CLOUDSTACK-351:
----------------------------------------
Thanks for the patch Musayev, Ilya
> cloud-set-guest-password.in - include double quotes for variable check when using -n in bash
> --------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-351
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-351
> Project: CloudStack
> Issue Type: Bug
> Components: Usage
> Affects Versions: 4.0.0
> Environment: RHEL/CENTOS 5.x/6.x and CS 3.x+/4.x+
> Reporter: ilya musayev
> Assignee: Rohit Yadav
> Priority: Minor
> Labels: patch
> Fix For: 4.0.0
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> include double quotes for variable check when using -n in bash - fixes one of issue when variable is present but not seen by bash
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CLOUDSTACK-351) cloud-set-guest-password.in -
include double quotes for variable check when using -n in bash
Posted by "Musayev, Ilya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476480#comment-13476480 ]
Musayev, Ilya commented on CLOUDSTACK-351:
------------------------------------------
I don’t think anyone committed it - I posted it an hour ago.
> cloud-set-guest-password.in - include double quotes for variable check when using -n in bash
> --------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-351
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-351
> Project: CloudStack
> Issue Type: Bug
> Components: Usage
> Affects Versions: 4.0.0
> Environment: RHEL/CENTOS 5.x/6.x and CS 3.x+/4.x+
> Reporter: ilya musayev
> Priority: Minor
> Labels: patch
> Fix For: 4.0.0
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> include double quotes for variable check when using -n in bash - fixes one of issue when variable is present but not seen by bash
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CLOUDSTACK-351) cloud-set-guest-password.in -
include double quotes for variable check when using -n in bash
Posted by "David Nalley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Nalley reopened CLOUDSTACK-351:
-------------------------------------
OK, lets leave it open til someone does get it committed - otherwise it disappears off folks radars.
Thanks for the patch btw.
--David
> cloud-set-guest-password.in - include double quotes for variable check when using -n in bash
> --------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-351
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-351
> Project: CloudStack
> Issue Type: Bug
> Components: Usage
> Affects Versions: 4.0.0
> Environment: RHEL/CENTOS 5.x/6.x and CS 3.x+/4.x+
> Reporter: ilya musayev
> Priority: Minor
> Labels: patch
> Fix For: 4.0.0
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> include double quotes for variable check when using -n in bash - fixes one of issue when variable is present but not seen by bash
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CLOUDSTACK-351) cloud-set-guest-password.in -
include double quotes for variable check when using -n in bash
Posted by "ilya musayev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ilya musayev resolved CLOUDSTACK-351.
-------------------------------------
Resolution: Fixed
diff --git a/setup/bindir/cloud-set-guest-password.in b/setup/bindir/cloud-set-guest-password.in
index 97e6e3d..69be175 100755
--- a/setup/bindir/cloud-set-guest-password.in
+++ b/setup/bindir/cloud-set-guest-password.in
@@ -39,7 +39,7 @@ do
file_count=$((file_count+1))
PASSWORD_SERVER_IP=$(grep dhcp-server-identifier $DHCP_FILE | tail -1 | awk '{print $NF}' | tr -d '\;')
- if [ -n $PASSWORD_SERVER_IP ]
+ if [ -n "$PASSWORD_SERVER_IP" ]
then
logger -t "cloud" "Found password server IP $PASSWORD_SERVER_IP in $DHCP_FILE"
logger -t "cloud" "Sending request to password server at $PASSWORD_SERVER_IP"
--
1.7.1
> cloud-set-guest-password.in - include double quotes for variable check when using -n in bash
> --------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-351
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-351
> Project: CloudStack
> Issue Type: Bug
> Components: Usage
> Affects Versions: 4.0.0
> Environment: RHEL/CENTOS 5.x/6.x and CS 3.x+/4.x+
> Reporter: ilya musayev
> Priority: Minor
> Labels: patch
> Fix For: 4.0.0
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> include double quotes for variable check when using -n in bash - fixes one of issue when variable is present but not seen by bash
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CLOUDSTACK-351) cloud-set-guest-password.in -
include double quotes for variable check when using -n in bash
Posted by "David Nalley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476405#comment-13476405 ]
David Nalley commented on CLOUDSTACK-351:
-----------------------------------------
Ilya: Has someone committed this code into the repo?
> cloud-set-guest-password.in - include double quotes for variable check when using -n in bash
> --------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-351
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-351
> Project: CloudStack
> Issue Type: Bug
> Components: Usage
> Affects Versions: 4.0.0
> Environment: RHEL/CENTOS 5.x/6.x and CS 3.x+/4.x+
> Reporter: ilya musayev
> Priority: Minor
> Labels: patch
> Fix For: 4.0.0
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> include double quotes for variable check when using -n in bash - fixes one of issue when variable is present but not seen by bash
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CLOUDSTACK-351) cloud-set-guest-password.in -
include double quotes for variable check when using -n in bash
Posted by "ilya b. musayev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477017#comment-13477017 ]
ilya b. musayev commented on CLOUDSTACK-351:
--------------------------------------------
Awesome, thank you.
Sent from my iPhone
> cloud-set-guest-password.in - include double quotes for variable check when using -n in bash
> --------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-351
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-351
> Project: CloudStack
> Issue Type: Bug
> Components: Usage
> Affects Versions: 4.0.0
> Environment: RHEL/CENTOS 5.x/6.x and CS 3.x+/4.x+
> Reporter: ilya musayev
> Assignee: Rohit Yadav
> Priority: Minor
> Labels: patch
> Fix For: 4.0.0
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> include double quotes for variable check when using -n in bash - fixes one of issue when variable is present but not seen by bash
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CLOUDSTACK-351) cloud-set-guest-password.in -
include double quotes for variable check when using -n in bash
Posted by "Rohit Yadav (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohit Yadav resolved CLOUDSTACK-351.
------------------------------------
Resolution: Duplicate
Assignee: Rohit Yadav
Already fixed, duplicate of https://issues.apache.org/jira/browse/CLOUDSTACK-321
This logic is applied in 4.0 and master for the two cloud-set-guest*.in scripts:
4.0:
commit 79b6450e2fe0d887204971c7c3cfe10889a8c342
Author: Ilya Musayev, CloudSand.com <il...@cloudsand.com>
AuthorDate: Fri Oct 12 01:18:16 2012 +0530
master:
commit 77ba46e322babca11132a7d4d7d5248802f2f2bd
Author: Ilya Musayev, CloudSand.com <il...@cloudsand.com>
AuthorDate: Fri Oct 12 01:18:16 2012 +0530
> cloud-set-guest-password.in - include double quotes for variable check when using -n in bash
> --------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-351
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-351
> Project: CloudStack
> Issue Type: Bug
> Components: Usage
> Affects Versions: 4.0.0
> Environment: RHEL/CENTOS 5.x/6.x and CS 3.x+/4.x+
> Reporter: ilya musayev
> Assignee: Rohit Yadav
> Priority: Minor
> Labels: patch
> Fix For: 4.0.0
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> include double quotes for variable check when using -n in bash - fixes one of issue when variable is present but not seen by bash
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira