[GitHub] [solr] risdenk commented on pull request #1506: WIP JDK 19

["risdenk (via GitHub)" <gi...@apache.org>]

risdenk commented on PR #1506:
URL: https://github.com/apache/solr/pull/1506#issuecomment-1490441853

   Mostly just testing it out to see if it works. I know there are some float issues with JDK 19 and errorprone - https://issues.apache.org/jira/browse/SOLR-16431 you can see it in the test above:
   
   ```
   > Task :solr:core:forbiddenApisMain
   /home/runner/work/solr/solr/solr/core/src/test/org/apache/solr/legacy/TestLegacyNumericUtils.java:269: warning: [FloatingPointLiteralPrecision] Floating point literal loses precision
   
             -9.9999999E+14f,
              ^
       (see https://errorprone.info/bugpattern/FloatingPointLiteralPrecision)
     Did you mean '-1.0E+15f,'?
   /home/runner/work/solr/solr/solr/core/src/test/org/apache/solr/legacy/TestLegacyNumericUtils.java:278: warning: [FloatingPointLiteralPrecision] Floating point literal loses precision
             9.9999999E+14f,
             ^
       (see https://errorprone.info/bugpattern/FloatingPointLiteralPrecision)
     Did you mean '1.0E+15f,'?
   error: warnings found and -Werror specified
   ```
   
   so not excluding JDK 17 by any means was just curious


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org