You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/21 16:50:03 UTC

[GitHub] [spark] zsxwing edited a comment on pull request #31219: [SPARK-34148][TEST][SS] Move general StateStore tests to StateStoreSuiteBase

zsxwing edited a comment on pull request #31219:
URL: https://github.com/apache/spark/pull/31219#issuecomment-764785055


   @dongjoon-hyun @viirya Great to hear that you are improving this. But I think committing code refactoring based on internal information is not a good pattern. Hence -1 for this change. It would be great if we can wait until a SPIP comes out so that other committers can evaluate whether this is useful.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org