[GitHub] [netbeans] tzezula commented on a change in pull request #2090: [NETBEANS-4037] Don't invalidate global classpath on JAR content change.

[GitBox <gi...@apache.org>]

tzezula commented on a change in pull request #2090:
URL: https://github.com/apache/netbeans/pull/2090#discussion_r412750855



##########
File path: ide/api.java.classpath/src/org/netbeans/api/java/classpath/ClassPath.java
##########
@@ -1415,7 +1415,9 @@ public void fileDataCreated(FileEvent fe) {
 
         @Override
         public void fileChanged(FileEvent fe) {
-            processEvent(fe);
+            if (!fe.getFile().isValid()) {

Review comment:
       This is in fact wrong and incompatible change.
   The `ClassPath.PROP_ROOTS` must be fired on content change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists