You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/10/08 05:23:26 UTC
[GitHub] junichi11 commented on a change in pull request #953:
[NETBEANS-1342] Hide the panel for iOS in the Mobile Platforms Options
junichi11 commented on a change in pull request #953: [NETBEANS-1342] Hide the panel for iOS in the Mobile Platforms Options
URL: https://github.com/apache/incubator-netbeans/pull/953#discussion_r223249858
##########
File path: webcommon/cordova/src/org/netbeans/modules/cordova/CordovaPerformer.java
##########
@@ -324,15 +325,16 @@ private Properties properties(Project p) {
props.put(PROP_ANDROID_PROJECT_ACTIVITY, activity);//NOI18N
MobilePlatform iosPlatform = PlatformManager.getPlatform(PlatformManager.IOS_TYPE);
+ if (iosPlatform != null) {
+ final String provisioningProfilePath = iosPlatform.getProvisioningProfilePath();
+ if (provisioningProfilePath != null) {
+ props.put(PROP_PROVISIONING_PROFILE, provisioningProfilePath);
+ }
+ final String codeSignIdentity = iosPlatform.getCodeSignIdentity();
- final String provisioningProfilePath = iosPlatform.getProvisioningProfilePath();
- if (provisioningProfilePath != null) {
- props.put(PROP_PROVISIONING_PROFILE, provisioningProfilePath);
- }
- final String codeSignIdentity = iosPlatform.getCodeSignIdentity();
-
- if (codeSignIdentity != null) {
- props.put(PROP_CERTIFICATE_NAME, codeSignIdentity);
+ if (codeSignIdentity != null) {
+ props.put(PROP_CERTIFICATE_NAME, codeSignIdentity);
+ }
}
//workaround for some strange behavior of ant execution in netbeans
Review comment:
You are right. Thanks for catching it. Will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists