You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/15 23:25:02 UTC
[GitHub] [spark] rxin edited a comment on issue #24129: [SPARK-27190][SQL]
add table capability for streaming
rxin edited a comment on issue #24129: [SPARK-27190][SQL] add table capability for streaming
URL: https://github.com/apache/spark/pull/24129#issuecomment-483454278
Ok FWIW, I think it's OK to separate new API introductions vs clean up internals that are already not ideal. It'd be great that we can get to the internal refactoring changes though.
I'm a lot more worried about you guys checking in changes that pollute existing public APIs without cleaning them up (e.g. the package location issues I pointed out already, and also InternalRows -- that one is bound to be a huge diaster).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org