[GitHub] [solr] dsmiley commented on a diff in pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

[GitBox <gi...@apache.org>]

dsmiley commented on code in PR #1048:
URL: https://github.com/apache/solr/pull/1048#discussion_r983869369


##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -741,16 +766,29 @@ public boolean split(ClusterState clusterState, ZkNodeProps message, NamedList<O
         } else {
           ccc.offerStateUpdate(Utils.toJSON(m));
         }
+

Review Comment:
   I feel that race deserves its own issue/pr.  @andyvuong if you don't want to create it, we can.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org