You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Bojan Smojver <bo...@rexursive.com> on 2006/04/23 23:58:05 UTC
[PATCH]: SQLite3 prepared statement support
These two patches enable prepared statements in SQLite3, for both the
trunk and 1.2.x. Surprisingly :-), I actually did test this code to
some extent, so the basics should be OK. However, please hammer it and
let me know.
--
Bojan
Re: [PATCH]: SQLite3 prepared statement support
Posted by Bojan Smojver <bo...@rexursive.com>.
Quoting Garrett Rooney <ro...@electricjellyfish.net>:
> I mean it's certainly no worse than it
> was before ;-)
He, he, you would think so... Before you would get an APR_ENOTIMPL
back. Now you get a brand new segfault ;-)
--
Bojan
Re: [PATCH]: SQLite3 prepared statement support
Posted by Bojan Smojver <bo...@rexursive.com>.
I reworked the prepared statement support for SQLite3 a little bit (the
linking of statements to the handle didn't really work in the original
patches and there was some unnecessary memory allocation as well). If
nobody objects, I would like to commit this to the trunk in the next few
days.
Not sure what to do about 1.2.x branch - does implementing functions
that were previously unimplemented cause binary compatibility flags to
be raised? I would think not, but I'll wait for explicit comments before
doing anything to the branch.
--
Bojan
Re: [PATCH]: SQLite3 prepared statement support
Posted by Bojan Smojver <bo...@rexursive.com>.
Quoting Bojan Smojver <bo...@rexursive.com>:
> These two patches
In the patch for the trunk, every apr_dbd_mutex_[un]lock(sql->mutex)
should not have sql->mutex argument, of course. Sorry about that -
I'll blame this one on early morning/lack of caffeine ;-)
--
Bojan