[GitHub] [superset] stephenLYZ edited a comment on pull request #17792: feat: improve color consistency

[GitBox <gi...@apache.org>]

stephenLYZ edited a comment on pull request #17792:
URL: https://github.com/apache/superset/pull/17792#issuecomment-1039209870


   @geido 
   
   1. The word map chart is not adapted. The way they use colorFn is a bit unusual,  so here I've adjusted it.
   2. This is expected. Before setting the color scheme, the default color scheme of each chart is uncertain, consider this scenario, when chart A is saved to dashboard, which color scheme is `supersetColors` , and chart B is set to `bnbColors`, at this time we should take which color scheme color as the consistency, I think this is a point worth discussing. 
   I think if user want to keep the color consistency, user need to set the color scheme for the dashboard instead of taking the default color scheme of each chart, which will lead to complicated problems.
   3. Yes. That's the problem. After applying dashboard, the metadata will be overwritten by the nativefilter's dispatch. Fixed here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org