You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "milenkovicm (via GitHub)" <gi...@apache.org> on 2025/04/24 16:59:21 UTC
[PR] feat: make execution_graph.stages() public [datafusion-ballista]
milenkovicm opened a new pull request, #1256:
URL: https://github.com/apache/datafusion-ballista/pull/1256
# Which issue does this PR close?
Closes #.
# Rationale for this change
this is follow up on ##1243 where I missed to name `stages()` public. Making stages public we can react on scheduler emitted events and inspect all stages for given job
# What changes are included in this PR?
- make single method public
# Are there any user-facing changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: make execution_graph.stages() public [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on code in PR #1256:
URL: https://github.com/apache/datafusion-ballista/pull/1256#discussion_r2065869484
##########
ballista/scheduler/src/state/execution_graph.rs:
##########
@@ -218,7 +218,7 @@ impl ExecutionGraph {
new_tid
}
- pub(crate) fn stages(&self) -> &HashMap<usize, ExecutionStage> {
+ pub fn stages(&self) -> &HashMap<usize, ExecutionStage> {
Review Comment:
created #1258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: make execution_graph.stages() public [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on code in PR #1256:
URL: https://github.com/apache/datafusion-ballista/pull/1256#discussion_r2065856812
##########
ballista/scheduler/src/state/execution_graph.rs:
##########
@@ -218,7 +218,7 @@ impl ExecutionGraph {
new_tid
}
- pub(crate) fn stages(&self) -> &HashMap<usize, ExecutionStage> {
+ pub fn stages(&self) -> &HashMap<usize, ExecutionStage> {
Review Comment:
fully agree with you, it'll be a good exercise for copilot one of the following weekends. will fix this one personally this time :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: make execution_graph.stages() public [datafusion-ballista]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #1256:
URL: https://github.com/apache/datafusion-ballista/pull/1256#discussion_r2064981773
##########
ballista/scheduler/src/state/execution_graph.rs:
##########
@@ -218,7 +218,7 @@ impl ExecutionGraph {
new_tid
}
- pub(crate) fn stages(&self) -> &HashMap<usize, ExecutionStage> {
+ pub fn stages(&self) -> &HashMap<usize, ExecutionStage> {
Review Comment:
nit: It would be good practice to start adding documentation on public methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: make execution_graph.stages() public [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm merged PR #1256:
URL: https://github.com/apache/datafusion-ballista/pull/1256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org