You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/02 18:40:31 UTC

[GitHub] [incubator-mxnet] szha commented on a change in pull request #17952: [v1.x][KVStore]1Bit gradient compression

szha commented on a change in pull request #17952:
URL: https://github.com/apache/incubator-mxnet/pull/17952#discussion_r585815419



##########
File path: src/kvstore/gradient_compression.cc
##########
@@ -124,14 +151,14 @@ void GradientCompression::Quantize(const mxnet::NDArray &from, mxnet::NDArray *t
         }, from.ctx(), {from.var()}, {to->var(), residual->var()},
         mxnet::FnProperty::kNormal, priority, "QuantizeGPU");
       } else {
-        LOG(FATAL) << "unknown device mask";
+        LOG(FATAL) << "Unsupported quantization of type " << get_type_str();
       }
+    } else {
+      LOG(FATAL) << "unknown device mask";

Review comment:
       log what devices are recieved.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org