You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "huaibingshifu (via GitHub)" <gi...@apache.org> on 2023/07/07 00:03:19 UTC
[GitHub] [dolphinscheduler] huaibingshifu opened a new issue, #14472: [Bug] [Datasource] 数据库连接参数修改不能生效
huaibingshifu opened a new issue, #14472:
URL: https://github.com/apache/dolphinscheduler/issues/14472
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
数据源连接参数修改，任务执行时没有生效
### What you expected to happen
数据源连接参数修改，任务执行时立即生效
### How to reproduce
修改数据源参数，任务执行还是用的之前的数据源参数
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #14472: [Bug] [Datasource] Modification of database connection parameters cannot take effect
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #14472: [Bug] [Datasource] Modification of database connection parameters cannot take effect
URL: https://github.com/apache/dolphinscheduler/issues/14472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #14472: [Bug] [Datasource] Modification of database connection parameters cannot take effect
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #14472:
URL: https://github.com/apache/dolphinscheduler/issues/14472#issuecomment-1678258750
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huaibingshifu commented on issue #14472: [Bug] [Datasource] Modification of database connection parameters cannot take effect
Posted by "huaibingshifu (via GitHub)" <gi...@apache.org>.
huaibingshifu commented on issue #14472:
URL: https://github.com/apache/dolphinscheduler/issues/14472#issuecomment-1624461530
获取缓存时，数据库连接参数修改，getDatasourceUniqueId没有改变。现做出如下修改让数据库连接参数修改在任务执行时立即生效。
修改之前代码：
```
@Override
public String getDatasourceUniqueId(ConnectionParam connectionParam, DbType dbType) {
BaseConnectionParam baseConnectionParam = (BaseConnectionParam) connectionParam;
return MessageFormat.format("{0}@{1}@{2}@{3}", dbType.getDescp(), baseConnectionParam.getUser(),
PasswordUtils.encodePassword(baseConnectionParam.getPassword()), baseConnectionParam.getJdbcUrl());
}
```
修改之后代码
```
@Override
public String getDatasourceUniqueId(ConnectionParam connectionParam, DbType dbType) {
BaseConnectionParam baseConnectionParam = (BaseConnectionParam) connectionParam;
return MessageFormat.format("{0}@{1}@{2}@{3}", dbType.getDescp(), baseConnectionParam.getUser(),
PasswordUtils.encodePassword(baseConnectionParam.getPassword()), getJdbcUrl(connectionParam));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #14472: [Bug] [Datasource] Modification of database connection parameters cannot take effect
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #14472:
URL: https://github.com/apache/dolphinscheduler/issues/14472#issuecomment-1667019169
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huaibingshifu commented on issue #14472: [Bug] [Datasource] Modification of database connection parameters cannot take effect
Posted by "huaibingshifu (via GitHub)" <gi...@apache.org>.
huaibingshifu commented on issue #14472:
URL: https://github.com/apache/dolphinscheduler/issues/14472#issuecomment-1624462611
@ruanwenjun @zhongjiajie Please help review, thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #14472: [Bug] [Datasource] Modification of database connection parameters cannot take effect
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #14472:
URL: https://github.com/apache/dolphinscheduler/issues/14472#issuecomment-1624453932
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Data source connection parameter modification does not take effect when the task is executed
### What you expected to happen
Data source connection parameter modification takes effect immediately when the task is executed
### How to reproduce
Modify the data source parameters, the task execution still uses the previous data source parameters
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org