[GitHub] ashb commented on issue #3851: AIRFLOW-3014 Increase possible length of passwords in connection table

[GitBox <gi...@apache.org>]

ashb commented on issue #3851: AIRFLOW-3014 Increase possible length of passwords in connection table
URL: https://github.com/apache/incubator-airflow/pull/3851#issuecomment-419018682
 
 
   It looks like SQLite doesn't actually enforce the max length on the columns:
   
   ```
   sqlite> insert into connection (password) values('aaaaaaaaaaaaaaaaaaaaaaaaa...a');
   sqlite> select id, length(password) from connection;
   1|1
   2|1900
   ```
   
   So maybe the fix is to simply not run this migration on sqlite engines? I'm some what surprised that the tests we added in #3516 didn't catch this (as the model already has the length set at 5000 but we were missing a migration to change it. (Which is nothing to do with this PR).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services