[jira] [Commented] (IGNITE-2832) CacheJdbcPojoStoreFactory.dataSource property should be replaced with Factory

["Semen Boikov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282501#comment-15282501 ] 

Semen Boikov commented on IGNITE-2832:
--------------------------------------

Reviewed, have few comments:
- there are no license headers in new files
- why two identical H2DataSourceFactory classes are needed?
- please add in javadoc for 'CacheJdbcPojoStoreFactory.setDataSource' something like 'deperecated, use factory or spring bean' instead


> CacheJdbcPojoStoreFactory.dataSource property should be replaced with Factory
> -----------------------------------------------------------------------------
>
>                 Key: IGNITE-2832
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2832
>             Project: Ignite
>          Issue Type: Improvement
>          Components: cache, community
>    Affects Versions: 1.5.0.final
>            Reporter: Valentin Kulichenko
>            Assignee: Pavel Konstantinov
>             Fix For: 1.6
>
>
> {{CacheJdbcPojoStoreFactory.dataSource}} property seems to be useless and confusing, because it's transient and therefore data source is lost when configuration is serialized.
> This property should be deprecated and replaced with {{Factory<DataSource>}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)