You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2026/08/26 17:37:11 UTC

[GH] (ofbiz-framework/trunk): Workflow run "Scorecard supply-chain security" is working again!

The GitHub Actions job "Scorecard supply-chain security" on ofbiz-framework.git/trunk has succeeded.
Run started by GitHub user ashishvijaywargiya (triggered by ashishvijaywargiya).

Head commit for run:
4cc9848625cfe4d22765167b6476573752f74c82 / Ashish Vijaywargiya <as...@apache.org>
Fixed: updateLayout authorizing under CONTENT_CREATE then updating unrelated records unchecked (#1745)

The updateLayout event built a Content value from caller-supplied
parameters and checked permission for it under the CONTENT_CREATE
operation, then separately loaded the real Content identified by
parameters.contentId and the real DataResource identified by
parameters.dataResourceId and stored both directly, without checking
UPDATE permission on either record and without any check that the
DataResource actually belonged to the Content.

A user holding only view-level Content Manager permissions could use an
existing RESPONSE-purpose Content to pass the CONTENT_CREATE check, then
relink that Content to an arbitrary DataResource and convert it into a
template-bearing (FTL) OFBIZ_FILE resource - a path the normal
updateDataResource service already blocks for the same user, since it
requires CONTENTMGR_SUPER for template-bearing DataResources.

Route both updates through the existing updateContent/updateDataResource
services instead, so permission is checked (via
genericContentPermission/ genericDataResourcePermission, main-action
UPDATE) against the real target records, the same way every other update
path in this component already works.

Added a regression test that creates a low-privilege user with only
OFBTOOLS_VIEW/CONTENTMGR_VIEW and verifies it is denied both when
updating an existing Content and when converting an existing
DataResource into a template-bearing OFBIZ_FILE resource.

Thank you Krishna Uprit for your help in reviewing the changes.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/32994940907

With regards,
GitHub Actions via GitBox