You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/06/28 07:07:05 UTC

[GitHub] [hudi] wangxianghu opened a new pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

wangxianghu opened a new pull request #3170:
URL: https://github.com/apache/hudi/pull/3170


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 641d1e6f0283b6476390a73594a75adde5f5cb9d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a655c71) into [master](https://codecov.io/gh/apache/hudi/commit/7895a3586e19a7f66fc2a400c90d8334f255d943?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7895a35) will **decrease** coverage by `9.21%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head a655c71 differs from pull request most recent head 8aa9611. Consider uploading reports for the commit 8aa9611 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   - Coverage     58.91%   49.69%   -9.22%     
   + Complexity     1194      405     -789     
   ============================================
     Files           163       67      -96     
     Lines          6435     2984    -3451     
     Branches        672      320     -352     
   ============================================
   - Hits           3791     1483    -2308     
   + Misses         2372     1365    -1007     
   + Partials        272      136     -136     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudiclient | `?` | |
   | hudiutilities | `49.69% <ø> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...apache/hudi/utilities/deltastreamer/DeltaSync.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvRGVsdGFTeW5jLmphdmE=) | `70.94% <0.00%> (-0.34%)` | :arrow_down: |
   | [...on/commit/SparkBulkInsertCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9TcGFya0J1bGtJbnNlcnRDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | | |
   | [...che/hudi/table/action/commit/SparkWriteHelper.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9TcGFya1dyaXRlSGVscGVyLmphdmE=) | | |
   | [.../java/org/apache/hudi/client/HoodieReadClient.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZVJlYWRDbGllbnQuamF2YQ==) | | |
   | [...un/strategy/SparkSortAndSizeExecutionStrategy.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2NsdXN0ZXJpbmcvcnVuL3N0cmF0ZWd5L1NwYXJrU29ydEFuZFNpemVFeGVjdXRpb25TdHJhdGVneS5qYXZh) | | |
   | [...trategy/SparkRecentDaysClusteringPlanStrategy.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2NsdXN0ZXJpbmcvcGxhbi9zdHJhdGVneS9TcGFya1JlY2VudERheXNDbHVzdGVyaW5nUGxhblN0cmF0ZWd5LmphdmE=) | | |
   | [...ble/action/clean/SparkCleanPlanActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NsZWFuL1NwYXJrQ2xlYW5QbGFuQWN0aW9uRXhlY3V0b3IuamF2YQ==) | | |
   | [...commit/SparkUpsertPreppedCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9TcGFya1Vwc2VydFByZXBwZWRDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | | |
   | [.../org/apache/hudi/index/SparkInMemoryHashIndex.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvU3BhcmtJbk1lbW9yeUhhc2hJbmRleC5qYXZh) | | |
   | [...compact/SparkScheduleCompactionActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvU3BhcmtTY2hlZHVsZUNvbXBhY3Rpb25BY3Rpb25FeGVjdXRvci5qYXZh) | | |
   | ... and [85 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7895a35...8aa9611](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on a change in pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r661319514



##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -353,14 +353,20 @@ private static int deduplicatePartitionPath(JavaSparkContext jsc, String duplica
 
   private static int doBootstrap(JavaSparkContext jsc, String tableName, String tableType, String basePath,
       String sourcePath, String recordKeyCols, String partitionFields, String parallelism, String schemaProviderClass,
-      String bootstrapIndexClass, String selectorClass, String keyGeneratorClass, String fullBootstrapInputProvider,
+      String bootstrapIndexClass, String selectorClass, String keyGenerator, String fullBootstrapInputProvider,
       String payloadClassName, String enableHiveSync, String propsFilePath, List<String> configs) throws IOException {
 
     TypedProperties properties = propsFilePath == null ? UtilHelpers.buildProperties(configs)
         : UtilHelpers.readConfig(FSUtils.getFs(propsFilePath, jsc.hadoopConfiguration()), new Path(propsFilePath), configs).getConfig();
 
     properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_BASE_PATH_PROP, sourcePath);
-    properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_KEYGEN_CLASS, keyGeneratorClass);
+    if (!StringUtils.isNullOrEmpty(keyGenerator)) {
+      if (keyGenerator.startsWith("org.apache.hudi")) {

Review comment:
       Can we make sure, whether all the customized key generators start with `org.apache.hudi`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=588",
       "triggerID" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff28cba39e0c88eb22406dabcad7e0517e6c2208",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=594",
       "triggerID" : "ff28cba39e0c88eb22406dabcad7e0517e6c2208",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 55bcca83acc0817f05ff7e9962920c810d45cae0 UNKNOWN
   * a655c7156fa5933c677dffb97d721e1ff7f695be UNKNOWN
   * fc5dd253a3b19d4b3e1c3d48b167afd7d505d788 UNKNOWN
   * ff28cba39e0c88eb22406dabcad7e0517e6c2208 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=594) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=588",
       "triggerID" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff28cba39e0c88eb22406dabcad7e0517e6c2208",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=594",
       "triggerID" : "ff28cba39e0c88eb22406dabcad7e0517e6c2208",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1b27bbdc32805058bbbe137772a9785e0f86ef5d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=623",
       "triggerID" : "1b27bbdc32805058bbbe137772a9785e0f86ef5d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 55bcca83acc0817f05ff7e9962920c810d45cae0 UNKNOWN
   * a655c7156fa5933c677dffb97d721e1ff7f695be UNKNOWN
   * fc5dd253a3b19d4b3e1c3d48b167afd7d505d788 UNKNOWN
   * 1b27bbdc32805058bbbe137772a9785e0f86ef5d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=623) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f838764) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **increase** coverage by `0.17%`.
   > The diff coverage is `18.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   + Coverage     46.01%   46.18%   +0.17%     
   - Complexity     5306     5385      +79     
   ============================================
     Files           911      921      +10     
     Lines         39476    40045     +569     
     Branches       4254     4297      +43     
   ============================================
   + Hits          18166    18496     +330     
   - Misses        19456    19662     +206     
   - Partials       1854     1887      +33     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `39.90% <0.00%> (-0.06%)` | :arrow_down: |
   | hudiclient | `30.43% <22.22%> (-0.01%)` | :arrow_down: |
   | hudicommon | `47.58% <ø> (+0.02%)` | :arrow_up: |
   | hudiflink | `60.06% <ø> (-1.27%)` | :arrow_down: |
   | hudihadoopmr | `51.29% <ø> (ø)` | |
   | hudisparkdatasource | `67.06% <ø> (+0.53%)` | :arrow_up: |
   | hudisync | `54.05% <ø> (+2.31%)` | :arrow_up: |
   | huditimelineservice | `64.36% <ø> (ø)` | |
   | hudiutilities | `58.40% <ø> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | `5.99% <0.00%> (-0.07%)` | :arrow_down: |
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `36.36% <0.00%> (-1.74%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `16.96% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...g/apache/hudi/utilities/schema/SchemaProvider.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFQcm92aWRlci5qYXZh) | `71.42% <0.00%> (-28.58%)` | :arrow_down: |
   | [...e/hudi/sink/partitioner/profile/WriteProfiles.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL3BhcnRpdGlvbmVyL3Byb2ZpbGUvV3JpdGVQcm9maWxlcy5qYXZh) | `46.80% <0.00%> (-5.70%)` | :arrow_down: |
   | [...java/org/apache/hudi/sink/StreamWriteFunction.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL1N0cmVhbVdyaXRlRnVuY3Rpb24uamF2YQ==) | `81.06% <0.00%> (-3.78%)` | :arrow_down: |
   | [...src/main/scala/org/apache/hudi/DefaultSource.scala](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0RlZmF1bHRTb3VyY2Uuc2NhbGE=) | `75.22% <0.00%> (-2.23%)` | :arrow_down: |
   | ... and [49 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...f838764](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on a change in pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r661144248



##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -353,14 +353,20 @@ private static int deduplicatePartitionPath(JavaSparkContext jsc, String duplica
 
   private static int doBootstrap(JavaSparkContext jsc, String tableName, String tableType, String basePath,

Review comment:
       yes, filed another ticket to rack this : https://issues.apache.org/jira/browse/HUDI-2104




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=588",
       "triggerID" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff28cba39e0c88eb22406dabcad7e0517e6c2208",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=594",
       "triggerID" : "ff28cba39e0c88eb22406dabcad7e0517e6c2208",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 55bcca83acc0817f05ff7e9962920c810d45cae0 UNKNOWN
   * a655c7156fa5933c677dffb97d721e1ff7f695be UNKNOWN
   * fc5dd253a3b19d4b3e1c3d48b167afd7d505d788 UNKNOWN
   * 8aa96119c018eaa1c6faf5eb1b527c90cad8315c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=588) 
   * ff28cba39e0c88eb22406dabcad7e0517e6c2208 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=594) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on a change in pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r662308139



##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/bootstrap/SparkBootstrapCommitActionExecutor.java
##########
@@ -390,8 +390,15 @@ private BootstrapWriteStatus handleMetadataBootstrap(String srcPartitionPath, St
 
     TypedProperties properties = new TypedProperties();
     properties.putAll(config.getProps());
-    KeyGeneratorInterface keyGenerator  = (KeyGeneratorInterface) ReflectionUtils.loadClass(config.getBootstrapKeyGeneratorClass(),
-        properties);
+
+    KeyGeneratorInterface keyGenerator;
+    try {
+      keyGenerator = HoodieSparkKeyGeneratorFactory.createKeyGenerator(properties);
+    } catch (IOException e) {
+      LOG.error("Init keyGenerator failed ", e);

Review comment:
       > Since we have thrown an exception, we may not need to add a log.
   
   removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=588",
       "triggerID" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581) 
   * 55bcca83acc0817f05ff7e9962920c810d45cae0 UNKNOWN
   * a655c7156fa5933c677dffb97d721e1ff7f695be UNKNOWN
   * fc5dd253a3b19d4b3e1c3d48b167afd7d505d788 UNKNOWN
   * 8aa96119c018eaa1c6faf5eb1b527c90cad8315c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=588) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua merged pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #3170:
URL: https://github.com/apache/hudi/pull/3170


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 641d1e6f0283b6476390a73594a75adde5f5cb9d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f838764919f2561ada6c9795f044106c9c338510 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509) 
   * a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869428495


   @yanghua please take l look when free


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f838764919f2561ada6c9795f044106c9c338510 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu closed pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu closed pull request #3170:
URL: https://github.com/apache/hudi/pull/3170


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f838764) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **decrease** coverage by `27.59%`.
   > The diff coverage is `11.11%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #3170       +/-   ##
   =============================================
   - Coverage     46.01%   18.42%   -27.60%     
   + Complexity     5306      871     -4435     
   =============================================
     Files           911      376      -535     
     Lines         39476    14340    -25136     
     Branches       4254     1459     -2795     
   =============================================
   - Hits          18166     2642    -15524     
   + Misses        19456    11534     -7922     
   + Partials       1854      164     -1690     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `?` | |
   | hudiclient | `22.27% <11.11%> (-8.18%)` | :arrow_down: |
   | hudicommon | `?` | |
   | hudiflink | `?` | |
   | hudihadoopmr | `?` | |
   | hudisparkdatasource | `?` | |
   | hudisync | `5.38% <ø> (-46.35%)` | :arrow_down: |
   | huditimelineservice | `?` | |
   | hudiutilities | `9.46% <ø> (-48.92%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `0.00% <0.00%> (-38.10%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-17.01%)` | :arrow_down: |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (-82.36%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/AvroSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/JsonSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvblNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [662 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...f838764](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f838764919f2561ada6c9795f044106c9c338510 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509) 
   * a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581) 
   * 55bcca83acc0817f05ff7e9962920c810d45cae0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869494725


   reopen to trigger the ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] [WIP] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 641d1e6f0283b6476390a73594a75adde5f5cb9d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=588",
       "triggerID" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff28cba39e0c88eb22406dabcad7e0517e6c2208",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ff28cba39e0c88eb22406dabcad7e0517e6c2208",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 55bcca83acc0817f05ff7e9962920c810d45cae0 UNKNOWN
   * a655c7156fa5933c677dffb97d721e1ff7f695be UNKNOWN
   * fc5dd253a3b19d4b3e1c3d48b167afd7d505d788 UNKNOWN
   * 8aa96119c018eaa1c6faf5eb1b527c90cad8315c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=588) 
   * ff28cba39e0c88eb22406dabcad7e0517e6c2208 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu closed pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu closed pull request #3170:
URL: https://github.com/apache/hudi/pull/3170


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on a change in pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r661106077



##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -353,14 +353,20 @@ private static int deduplicatePartitionPath(JavaSparkContext jsc, String duplica
 
   private static int doBootstrap(JavaSparkContext jsc, String tableName, String tableType, String basePath,

Review comment:
       The original parameter list is not very graceful. I suggest we can only receive `args`, then use a builder to build(extract) the metadata of the bootstrap action. wdyt?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f838764) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **increase** coverage by `0.17%`.
   > The diff coverage is `18.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   + Coverage     46.01%   46.19%   +0.17%     
   - Complexity     5306     5386      +80     
   ============================================
     Files           911      921      +10     
     Lines         39476    40045     +569     
     Branches       4254     4297      +43     
   ============================================
   + Hits          18166    18497     +331     
   - Misses        19456    19662     +206     
   - Partials       1854     1886      +32     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `39.90% <0.00%> (-0.06%)` | :arrow_down: |
   | hudiclient | `30.43% <22.22%> (-0.01%)` | :arrow_down: |
   | hudicommon | `47.58% <ø> (+0.02%)` | :arrow_up: |
   | hudiflink | `60.06% <ø> (-1.27%)` | :arrow_down: |
   | hudihadoopmr | `51.29% <ø> (ø)` | |
   | hudisparkdatasource | `67.06% <ø> (+0.53%)` | :arrow_up: |
   | hudisync | `54.05% <ø> (+2.31%)` | :arrow_up: |
   | huditimelineservice | `64.36% <ø> (ø)` | |
   | hudiutilities | `58.44% <ø> (+0.06%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | `5.99% <0.00%> (-0.07%)` | :arrow_down: |
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `36.36% <0.00%> (-1.74%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `16.96% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...g/apache/hudi/utilities/schema/SchemaProvider.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFQcm92aWRlci5qYXZh) | `71.42% <0.00%> (-28.58%)` | :arrow_down: |
   | [...e/hudi/sink/partitioner/profile/WriteProfiles.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL3BhcnRpdGlvbmVyL3Byb2ZpbGUvV3JpdGVQcm9maWxlcy5qYXZh) | `46.80% <0.00%> (-5.70%)` | :arrow_down: |
   | [...java/org/apache/hudi/sink/StreamWriteFunction.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL1N0cmVhbVdyaXRlRnVuY3Rpb24uamF2YQ==) | `81.06% <0.00%> (-3.78%)` | :arrow_down: |
   | [...src/main/scala/org/apache/hudi/DefaultSource.scala](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0RlZmF1bHRTb3VyY2Uuc2NhbGE=) | `75.22% <0.00%> (-2.23%)` | :arrow_down: |
   | ... and [49 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...f838764](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581) 
   * 55bcca83acc0817f05ff7e9962920c810d45cae0 UNKNOWN
   * a655c7156fa5933c677dffb97d721e1ff7f695be UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter commented on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (641d1e6) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **decrease** coverage by `27.56%`.
   > The diff coverage is `11.11%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #3170       +/-   ##
   =============================================
   - Coverage     46.01%   18.45%   -27.57%     
   + Complexity     5306      871     -4435     
   =============================================
     Files           911      375      -536     
     Lines         39476    14318    -25158     
     Branches       4254     1460     -2794     
   =============================================
   - Hits          18166     2642    -15524     
   + Misses        19456    11512     -7944     
   + Partials       1854      164     -1690     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `?` | |
   | hudiclient | `22.27% <11.11%> (-8.18%)` | :arrow_down: |
   | hudicommon | `?` | |
   | hudiflink | `?` | |
   | hudihadoopmr | `?` | |
   | hudisparkdatasource | `?` | |
   | hudisync | `5.38% <ø> (-46.35%)` | :arrow_down: |
   | huditimelineservice | `?` | |
   | hudiutilities | `9.53% <ø> (-48.85%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `0.00% <0.00%> (-38.10%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-17.01%)` | :arrow_down: |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (-82.36%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/AvroSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/JsonSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvblNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [661 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...641d1e6](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 641d1e6f0283b6476390a73594a75adde5f5cb9d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482) 
   * f838764919f2561ada6c9795f044106c9c338510 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc5dd25) into [master](https://codecov.io/gh/apache/hudi/commit/7895a3586e19a7f66fc2a400c90d8334f255d943?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7895a35) will **decrease** coverage by `0.04%`.
   > The diff coverage is `20.00%`.
   
   > :exclamation: Current head fc5dd25 differs from pull request most recent head 8aa9611. Consider uploading reports for the commit 8aa9611 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   - Coverage     58.91%   58.86%   -0.05%     
   - Complexity     1194     1195       +1     
   ============================================
     Files           163      163              
     Lines          6435     6442       +7     
     Branches        672      672              
   ============================================
   + Hits           3791     3792       +1     
   - Misses         2372     2377       +5     
   - Partials        272      273       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudiclient | `66.74% <20.00%> (-0.11%)` | :arrow_down: |
   | hudiutilities | `49.73% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7895a35...8aa9611](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on a change in pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r662308773



##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -353,14 +354,20 @@ private static int deduplicatePartitionPath(JavaSparkContext jsc, String duplica
 
   private static int doBootstrap(JavaSparkContext jsc, String tableName, String tableType, String basePath,
       String sourcePath, String recordKeyCols, String partitionFields, String parallelism, String schemaProviderClass,
-      String bootstrapIndexClass, String selectorClass, String keyGeneratorClass, String fullBootstrapInputProvider,
+      String bootstrapIndexClass, String selectorClass, String keyGenerator, String fullBootstrapInputProvider,
       String payloadClassName, String enableHiveSync, String propsFilePath, List<String> configs) throws IOException {
 
     TypedProperties properties = propsFilePath == null ? UtilHelpers.buildProperties(configs)
         : UtilHelpers.readConfig(FSUtils.getFs(propsFilePath, jsc.hadoopConfiguration()), new Path(propsFilePath), configs).getConfig();
 
     properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_BASE_PATH_PROP.key(), sourcePath);
-    properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_KEYGEN_CLASS.key(), keyGeneratorClass);
+
+    if (KeyGeneratorType.getNames().contains(keyGenerator)) {

Review comment:
       > it should be `contains` or `equals` or `equals ignore case sensitive`？
   
   This `getNames()` returns  a list, should use `contains`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-872267448


   @yanghua I have addressed all your concerns, please PTAL when get time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581) 
   * 55bcca83acc0817f05ff7e9962920c810d45cae0 UNKNOWN
   * a655c7156fa5933c677dffb97d721e1ff7f695be UNKNOWN
   * fc5dd253a3b19d4b3e1c3d48b167afd7d505d788 UNKNOWN
   * 8aa96119c018eaa1c6faf5eb1b527c90cad8315c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff28cba) into [master](https://codecov.io/gh/apache/hudi/commit/d07def12901485a9d59ab2b54602d535f00e5986?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d07def1) will **decrease** coverage by `44.61%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #3170       +/-   ##
   ============================================
   - Coverage     47.50%   2.88%   -44.62%     
   + Complexity     5430      82     -5348     
   ============================================
     Files           922     280      -642     
     Lines         40960   11563    -29397     
     Branches       4105     946     -3159     
   ============================================
   - Hits          19459     334    -19125     
   + Misses        19779   11203     -8576     
   + Partials       1722      26     -1696     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `?` | |
   | hudiclient | `0.00% <0.00%> (-34.56%)` | :arrow_down: |
   | hudicommon | `?` | |
   | hudiflink | `?` | |
   | hudihadoopmr | `?` | |
   | hudisparkdatasource | `?` | |
   | hudisync | `5.38% <ø> (-48.67%)` | :arrow_down: |
   | huditimelineservice | `?` | |
   | hudiutilities | `9.31% <ø> (-48.73%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `0.00% <0.00%> (-72.98%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-42.79%)` | :arrow_down: |
   | [.../apache/hudi/keygen/constant/KeyGeneratorType.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9jb25zdGFudC9LZXlHZW5lcmF0b3JUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (-82.36%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/AvroSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/JsonSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvblNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rg/apache/hudi/utilities/sources/CsvDFSSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQ3N2REZTU291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [758 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d07def1...ff28cba](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on a change in pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r661320980



##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -353,14 +353,20 @@ private static int deduplicatePartitionPath(JavaSparkContext jsc, String duplica
 
   private static int doBootstrap(JavaSparkContext jsc, String tableName, String tableType, String basePath,
       String sourcePath, String recordKeyCols, String partitionFields, String parallelism, String schemaProviderClass,
-      String bootstrapIndexClass, String selectorClass, String keyGeneratorClass, String fullBootstrapInputProvider,
+      String bootstrapIndexClass, String selectorClass, String keyGenerator, String fullBootstrapInputProvider,
       String payloadClassName, String enableHiveSync, String propsFilePath, List<String> configs) throws IOException {
 
     TypedProperties properties = propsFilePath == null ? UtilHelpers.buildProperties(configs)
         : UtilHelpers.readConfig(FSUtils.getFs(propsFilePath, jsc.hadoopConfiguration()), new Path(propsFilePath), configs).getConfig();
 
     properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_BASE_PATH_PROP, sourcePath);
-    properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_KEYGEN_CLASS, keyGeneratorClass);
+    if (!StringUtils.isNullOrEmpty(keyGenerator)) {
+      if (keyGenerator.startsWith("org.apache.hudi")) {

Review comment:
       > Can we make sure, whether all the customized key generators start with `org.apache.hudi`?
   
   we can




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f838764) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **decrease** coverage by `3.42%`.
   > The diff coverage is `18.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   - Coverage     46.01%   42.59%   -3.43%     
   + Complexity     5306     4994     -312     
   ============================================
     Files           911      921      +10     
     Lines         39476    40045     +569     
     Branches       4254     4297      +43     
   ============================================
   - Hits          18166    17056    -1110     
   - Misses        19456    21234    +1778     
   + Partials       1854     1755      -99     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `39.90% <0.00%> (-0.06%)` | :arrow_down: |
   | hudiclient | `30.43% <22.22%> (-0.01%)` | :arrow_down: |
   | hudicommon | `47.56% <ø> (+<0.01%)` | :arrow_up: |
   | hudiflink | `60.06% <ø> (-1.27%)` | :arrow_down: |
   | hudihadoopmr | `51.29% <ø> (ø)` | |
   | hudisparkdatasource | `67.06% <ø> (+0.53%)` | :arrow_up: |
   | hudisync | `54.05% <ø> (+2.31%)` | :arrow_up: |
   | huditimelineservice | `64.36% <ø> (ø)` | |
   | hudiutilities | `9.46% <ø> (-48.92%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | `5.99% <0.00%> (-0.07%)` | :arrow_down: |
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `36.36% <0.00%> (-1.74%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `16.96% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/AvroSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [88 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...f838764](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f838764) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **increase** coverage by `0.17%`.
   > The diff coverage is `18.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   + Coverage     46.01%   46.18%   +0.17%     
   - Complexity     5306     5385      +79     
   ============================================
     Files           911      921      +10     
     Lines         39476    40045     +569     
     Branches       4254     4297      +43     
   ============================================
   + Hits          18166    18496     +330     
   - Misses        19456    19662     +206     
   - Partials       1854     1887      +33     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `39.90% <0.00%> (-0.06%)` | :arrow_down: |
   | hudiclient | `30.43% <22.22%> (-0.01%)` | :arrow_down: |
   | hudicommon | `47.58% <ø> (+0.02%)` | :arrow_up: |
   | hudiflink | `60.06% <ø> (-1.27%)` | :arrow_down: |
   | hudihadoopmr | `51.29% <ø> (ø)` | |
   | hudisparkdatasource | `67.06% <ø> (+0.53%)` | :arrow_up: |
   | hudisync | `54.05% <ø> (+2.31%)` | :arrow_up: |
   | huditimelineservice | `64.36% <ø> (ø)` | |
   | hudiutilities | `58.40% <ø> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | `5.99% <0.00%> (-0.07%)` | :arrow_down: |
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `36.36% <0.00%> (-1.74%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `16.96% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...g/apache/hudi/utilities/schema/SchemaProvider.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFQcm92aWRlci5qYXZh) | `71.42% <0.00%> (-28.58%)` | :arrow_down: |
   | [...e/hudi/sink/partitioner/profile/WriteProfiles.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL3BhcnRpdGlvbmVyL3Byb2ZpbGUvV3JpdGVQcm9maWxlcy5qYXZh) | `46.80% <0.00%> (-5.70%)` | :arrow_down: |
   | [...java/org/apache/hudi/sink/StreamWriteFunction.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL1N0cmVhbVdyaXRlRnVuY3Rpb24uamF2YQ==) | `81.06% <0.00%> (-3.78%)` | :arrow_down: |
   | [...src/main/scala/org/apache/hudi/DefaultSource.scala](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0RlZmF1bHRTb3VyY2Uuc2NhbGE=) | `75.22% <0.00%> (-2.23%)` | :arrow_down: |
   | ... and [49 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...f838764](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on a change in pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r661936888



##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -353,14 +353,20 @@ private static int deduplicatePartitionPath(JavaSparkContext jsc, String duplica
 
   private static int doBootstrap(JavaSparkContext jsc, String tableName, String tableType, String basePath,
       String sourcePath, String recordKeyCols, String partitionFields, String parallelism, String schemaProviderClass,
-      String bootstrapIndexClass, String selectorClass, String keyGeneratorClass, String fullBootstrapInputProvider,
+      String bootstrapIndexClass, String selectorClass, String keyGenerator, String fullBootstrapInputProvider,
       String payloadClassName, String enableHiveSync, String propsFilePath, List<String> configs) throws IOException {
 
     TypedProperties properties = propsFilePath == null ? UtilHelpers.buildProperties(configs)
         : UtilHelpers.readConfig(FSUtils.getFs(propsFilePath, jsc.hadoopConfiguration()), new Path(propsFilePath), configs).getConfig();
 
     properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_BASE_PATH_PROP, sourcePath);
-    properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_KEYGEN_CLASS, keyGeneratorClass);
+    if (!StringUtils.isNullOrEmpty(keyGenerator)) {
+      if (keyGenerator.startsWith("org.apache.hudi")) {

Review comment:
       > Can we make sure, whether all the customized key generators start with `org.apache.hudi`?
   
   @yanghua  Fixed, PTAL




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8aa9611) into [master](https://codecov.io/gh/apache/hudi/commit/7895a3586e19a7f66fc2a400c90d8334f255d943?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7895a35) will **decrease** coverage by `0.06%`.
   > The diff coverage is `20.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   - Coverage     58.91%   58.84%   -0.07%     
     Complexity     1194     1194              
   ============================================
     Files           163      163              
     Lines          6435     6442       +7     
     Branches        672      672              
   ============================================
     Hits           3791     3791              
   - Misses         2372     2377       +5     
   - Partials        272      274       +2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudiclient | `66.74% <20.00%> (-0.11%)` | :arrow_down: |
   | hudiutilities | `49.69% <ø> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...apache/hudi/utilities/deltastreamer/DeltaSync.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvRGVsdGFTeW5jLmphdmE=) | `70.94% <0.00%> (-0.34%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7895a35...8aa9611](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu closed pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu closed pull request #3170:
URL: https://github.com/apache/hudi/pull/3170


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f838764) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **increase** coverage by `0.17%`.
   > The diff coverage is `18.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   + Coverage     46.01%   46.19%   +0.17%     
   - Complexity     5306     5386      +80     
   ============================================
     Files           911      921      +10     
     Lines         39476    40045     +569     
     Branches       4254     4297      +43     
   ============================================
   + Hits          18166    18497     +331     
   - Misses        19456    19662     +206     
   - Partials       1854     1886      +32     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `39.90% <0.00%> (-0.06%)` | :arrow_down: |
   | hudiclient | `30.43% <22.22%> (-0.01%)` | :arrow_down: |
   | hudicommon | `47.58% <ø> (+0.02%)` | :arrow_up: |
   | hudiflink | `60.06% <ø> (-1.27%)` | :arrow_down: |
   | hudihadoopmr | `51.29% <ø> (ø)` | |
   | hudisparkdatasource | `67.06% <ø> (+0.53%)` | :arrow_up: |
   | hudisync | `54.05% <ø> (+2.31%)` | :arrow_up: |
   | huditimelineservice | `64.36% <ø> (ø)` | |
   | hudiutilities | `58.44% <ø> (+0.06%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | `5.99% <0.00%> (-0.07%)` | :arrow_down: |
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `36.36% <0.00%> (-1.74%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `16.96% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...g/apache/hudi/utilities/schema/SchemaProvider.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFQcm92aWRlci5qYXZh) | `71.42% <0.00%> (-28.58%)` | :arrow_down: |
   | [...e/hudi/sink/partitioner/profile/WriteProfiles.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL3BhcnRpdGlvbmVyL3Byb2ZpbGUvV3JpdGVQcm9maWxlcy5qYXZh) | `46.80% <0.00%> (-5.70%)` | :arrow_down: |
   | [...java/org/apache/hudi/sink/StreamWriteFunction.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL1N0cmVhbVdyaXRlRnVuY3Rpb24uamF2YQ==) | `81.06% <0.00%> (-3.78%)` | :arrow_down: |
   | [...src/main/scala/org/apache/hudi/DefaultSource.scala](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0RlZmF1bHRTb3VyY2Uuc2NhbGE=) | `75.22% <0.00%> (-2.23%)` | :arrow_down: |
   | ... and [49 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...f838764](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f838764) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **decrease** coverage by `42.94%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #3170       +/-   ##
   ============================================
   - Coverage     46.01%   3.06%   -42.95%     
   + Complexity     5306      82     -5224     
   ============================================
     Files           911     280      -631     
     Lines         39476   10882    -28594     
     Branches       4254    1107     -3147     
   ============================================
   - Hits          18166     334    -17832     
   + Misses        19456   10522     -8934     
   + Partials       1854      26     -1828     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `?` | |
   | hudiclient | `0.00% <0.00%> (-30.45%)` | :arrow_down: |
   | hudicommon | `?` | |
   | hudiflink | `?` | |
   | hudihadoopmr | `?` | |
   | hudisparkdatasource | `?` | |
   | hudisync | `5.38% <ø> (-46.35%)` | :arrow_down: |
   | huditimelineservice | `?` | |
   | hudiutilities | `9.46% <ø> (-48.92%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `0.00% <0.00%> (-38.10%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-17.01%)` | :arrow_down: |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (-82.36%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/AvroSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/JsonSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvblNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rg/apache/hudi/utilities/sources/CsvDFSSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQ3N2REZTU291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...g/apache/hudi/utilities/sources/JsonDFSSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvbkRGU1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [753 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...f838764](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu closed pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu closed pull request #3170:
URL: https://github.com/apache/hudi/pull/3170






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (641d1e6) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **decrease** coverage by `3.32%`.
   > The diff coverage is `18.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   - Coverage     46.01%   42.69%   -3.33%     
   + Complexity     5306     4979     -327     
   ============================================
     Files           911      920       +9     
     Lines         39476    39845     +369     
     Branches       4254     4295      +41     
   ============================================
   - Hits          18166    17010    -1156     
   - Misses        19456    21085    +1629     
   + Partials       1854     1750     -104     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `39.90% <0.00%> (-0.06%)` | :arrow_down: |
   | hudiclient | `30.44% <22.22%> (-0.01%)` | :arrow_down: |
   | hudicommon | `47.58% <ø> (+0.02%)` | :arrow_up: |
   | hudiflink | `61.54% <ø> (+0.20%)` | :arrow_up: |
   | hudihadoopmr | `51.29% <ø> (ø)` | |
   | hudisparkdatasource | `67.06% <ø> (+0.53%)` | :arrow_up: |
   | hudisync | `54.05% <ø> (+2.31%)` | :arrow_up: |
   | huditimelineservice | `64.36% <ø> (ø)` | |
   | hudiutilities | `9.53% <ø> (-48.85%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | `5.99% <0.00%> (-0.07%)` | :arrow_down: |
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `36.36% <0.00%> (-1.74%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `16.96% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/AvroSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [80 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...641d1e6](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (641d1e6) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **decrease** coverage by `3.44%`.
   > The diff coverage is `18.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   - Coverage     46.01%   42.57%   -3.45%     
   + Complexity     5306     4979     -327     
   ============================================
     Files           911      921      +10     
     Lines         39476    39953     +477     
     Branches       4254     4314      +60     
   ============================================
   - Hits          18166    17010    -1156     
   - Misses        19456    21193    +1737     
   + Partials       1854     1750     -104     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `39.90% <0.00%> (-0.06%)` | :arrow_down: |
   | hudiclient | `30.44% <22.22%> (-0.01%)` | :arrow_down: |
   | hudicommon | `47.58% <ø> (+0.02%)` | :arrow_up: |
   | hudiflink | `61.54% <ø> (+0.20%)` | :arrow_up: |
   | hudihadoopmr | `51.29% <ø> (ø)` | |
   | hudisparkdatasource | `67.06% <ø> (+0.53%)` | :arrow_up: |
   | hudisync | `54.05% <ø> (+2.31%)` | :arrow_up: |
   | huditimelineservice | `64.36% <ø> (ø)` | |
   | hudiutilities | `9.19% <ø> (-49.19%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | `5.99% <0.00%> (-0.07%)` | :arrow_down: |
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `36.36% <0.00%> (-1.74%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `16.96% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/AvroSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [81 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...641d1e6](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=588",
       "triggerID" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff28cba39e0c88eb22406dabcad7e0517e6c2208",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=594",
       "triggerID" : "ff28cba39e0c88eb22406dabcad7e0517e6c2208",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1b27bbdc32805058bbbe137772a9785e0f86ef5d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1b27bbdc32805058bbbe137772a9785e0f86ef5d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 55bcca83acc0817f05ff7e9962920c810d45cae0 UNKNOWN
   * a655c7156fa5933c677dffb97d721e1ff7f695be UNKNOWN
   * fc5dd253a3b19d4b3e1c3d48b167afd7d505d788 UNKNOWN
   * ff28cba39e0c88eb22406dabcad7e0517e6c2208 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=594) 
   * 1b27bbdc32805058bbbe137772a9785e0f86ef5d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff28cba) into [master](https://codecov.io/gh/apache/hudi/commit/d07def12901485a9d59ab2b54602d535f00e5986?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d07def1) will **decrease** coverage by `20.23%`.
   > The diff coverage is `7.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #3170       +/-   ##
   =============================================
   - Coverage     47.50%   27.26%   -20.24%     
   + Complexity     5430     1268     -4162     
   =============================================
     Files           922      376      -546     
     Lines         40960    15021    -25939     
     Branches       4105     1298     -2807     
   =============================================
   - Hits          19459     4096    -15363     
   + Misses        19779    10629     -9150     
   + Partials       1722      296     -1426     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `?` | |
   | hudiclient | `20.98% <7.14%> (-13.57%)` | :arrow_down: |
   | hudicommon | `?` | |
   | hudiflink | `?` | |
   | hudihadoopmr | `?` | |
   | hudisparkdatasource | `?` | |
   | hudisync | `5.38% <ø> (-48.67%)` | :arrow_down: |
   | huditimelineservice | `?` | |
   | hudiutilities | `58.04% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `0.00% <0.00%> (-72.98%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-42.79%)` | :arrow_down: |
   | [.../apache/hudi/keygen/constant/KeyGeneratorType.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9jb25zdGFudC9LZXlHZW5lcmF0b3JUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (-82.36%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/metrics/HoodieGauge.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldHJpY3MvSG9vZGllR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/hive/NonPartitionedExtractor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvTm9uUGFydGl0aW9uZWRFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../java/org/apache/hudi/metrics/MetricsReporter.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldHJpY3MvTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldHJpY3MvTWV0cmljc1JlcG9ydGVyVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [619 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d07def1...ff28cba](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (641d1e6) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **decrease** coverage by `3.33%`.
   > The diff coverage is `18.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   - Coverage     46.01%   42.68%   -3.34%     
   + Complexity     5306     4979     -327     
   ============================================
     Files           911      920       +9     
     Lines         39476    39841     +365     
     Branches       4254     4292      +38     
   ============================================
   - Hits          18166    17006    -1160     
   - Misses        19456    21085    +1629     
   + Partials       1854     1750     -104     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `39.90% <0.00%> (-0.06%)` | :arrow_down: |
   | hudiclient | `30.44% <22.22%> (-0.01%)` | :arrow_down: |
   | hudicommon | `47.58% <ø> (+0.02%)` | :arrow_up: |
   | hudiflink | `61.50% <ø> (+0.16%)` | :arrow_up: |
   | hudihadoopmr | `51.29% <ø> (ø)` | |
   | hudisparkdatasource | `67.06% <ø> (+0.53%)` | :arrow_up: |
   | hudisync | `54.05% <ø> (+2.31%)` | :arrow_up: |
   | huditimelineservice | `64.36% <ø> (ø)` | |
   | hudiutilities | `9.53% <ø> (-48.85%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | `5.99% <0.00%> (-0.07%)` | :arrow_down: |
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `36.36% <0.00%> (-1.74%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `16.96% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/AvroSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [79 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...641d1e6](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f838764) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **decrease** coverage by `3.42%`.
   > The diff coverage is `18.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   - Coverage     46.01%   42.59%   -3.43%     
   + Complexity     5306     4994     -312     
   ============================================
     Files           911      921      +10     
     Lines         39476    40045     +569     
     Branches       4254     4297      +43     
   ============================================
   - Hits          18166    17056    -1110     
   - Misses        19456    21234    +1778     
   + Partials       1854     1755      -99     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `39.90% <0.00%> (-0.06%)` | :arrow_down: |
   | hudiclient | `30.43% <22.22%> (-0.01%)` | :arrow_down: |
   | hudicommon | `47.56% <ø> (+<0.01%)` | :arrow_up: |
   | hudiflink | `60.06% <ø> (-1.27%)` | :arrow_down: |
   | hudihadoopmr | `51.29% <ø> (ø)` | |
   | hudisparkdatasource | `67.06% <ø> (+0.53%)` | :arrow_up: |
   | hudisync | `54.05% <ø> (+2.31%)` | :arrow_up: |
   | huditimelineservice | `64.36% <ø> (ø)` | |
   | hudiutilities | `9.46% <ø> (-48.92%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | `5.99% <0.00%> (-0.07%)` | :arrow_down: |
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `36.36% <0.00%> (-1.74%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `16.96% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/utilities/sources/AvroSource.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [88 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...f838764](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu closed pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu closed pull request #3170:
URL: https://github.com/apache/hudi/pull/3170


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581) 
   * 55bcca83acc0817f05ff7e9962920c810d45cae0 UNKNOWN
   * a655c7156fa5933c677dffb97d721e1ff7f695be UNKNOWN
   * fc5dd253a3b19d4b3e1c3d48b167afd7d505d788 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on a change in pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r662256578



##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java
##########
@@ -54,7 +59,12 @@ public static KeyGenerator createKeyGenerator(TypedProperties props) throws IOEx
   private static BuiltinKeyGenerator createKeyGeneratorByType(TypedProperties props) throws IOException {
     // Use KeyGeneratorType.SIMPLE as default keyGeneratorType
     String keyGeneratorType =
-        props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE_PROP.key(), KeyGeneratorType.SIMPLE.name());

Review comment:
       Why do we need to refactor this? For adding a log message?

##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -353,14 +354,20 @@ private static int deduplicatePartitionPath(JavaSparkContext jsc, String duplica
 
   private static int doBootstrap(JavaSparkContext jsc, String tableName, String tableType, String basePath,
       String sourcePath, String recordKeyCols, String partitionFields, String parallelism, String schemaProviderClass,
-      String bootstrapIndexClass, String selectorClass, String keyGeneratorClass, String fullBootstrapInputProvider,
+      String bootstrapIndexClass, String selectorClass, String keyGenerator, String fullBootstrapInputProvider,
       String payloadClassName, String enableHiveSync, String propsFilePath, List<String> configs) throws IOException {
 
     TypedProperties properties = propsFilePath == null ? UtilHelpers.buildProperties(configs)
         : UtilHelpers.readConfig(FSUtils.getFs(propsFilePath, jsc.hadoopConfiguration()), new Path(propsFilePath), configs).getConfig();
 
     properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_BASE_PATH_PROP.key(), sourcePath);
-    properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_KEYGEN_CLASS.key(), keyGeneratorClass);
+
+    if (KeyGeneratorType.getNames().contains(keyGenerator)) {

Review comment:
       it should be `contains` or `equals` or `equals ignore case sensitive`？

##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java
##########
@@ -31,6 +32,8 @@
 import org.apache.hudi.keygen.SimpleKeyGenerator;
 import org.apache.hudi.keygen.TimestampBasedKeyGenerator;
 import org.apache.hudi.keygen.constant.KeyGeneratorType;
+import org.slf4j.Logger;

Review comment:
       follow the rule of import orders

##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/bootstrap/SparkBootstrapCommitActionExecutor.java
##########
@@ -390,8 +390,15 @@ private BootstrapWriteStatus handleMetadataBootstrap(String srcPartitionPath, St
 
     TypedProperties properties = new TypedProperties();
     properties.putAll(config.getProps());
-    KeyGeneratorInterface keyGenerator  = (KeyGeneratorInterface) ReflectionUtils.loadClass(config.getBootstrapKeyGeneratorClass(),
-        properties);
+
+    KeyGeneratorInterface keyGenerator;
+    try {
+      keyGenerator = HoodieSparkKeyGeneratorFactory.createKeyGenerator(properties);
+    } catch (IOException e) {
+      LOG.error("Init keyGenerator failed ", e);

Review comment:
       Since we have thrown an exception, we may not need to add a log.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f838764) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **increase** coverage by `0.17%`.
   > The diff coverage is `18.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   + Coverage     46.01%   46.19%   +0.17%     
   - Complexity     5306     5386      +80     
   ============================================
     Files           911      921      +10     
     Lines         39476    40045     +569     
     Branches       4254     4297      +43     
   ============================================
   + Hits          18166    18497     +331     
   - Misses        19456    19662     +206     
   - Partials       1854     1886      +32     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `39.90% <0.00%> (-0.06%)` | :arrow_down: |
   | hudiclient | `30.43% <22.22%> (-0.01%)` | :arrow_down: |
   | hudicommon | `47.58% <ø> (+0.02%)` | :arrow_up: |
   | hudiflink | `60.06% <ø> (-1.27%)` | :arrow_down: |
   | hudihadoopmr | `51.29% <ø> (ø)` | |
   | hudisparkdatasource | `67.06% <ø> (+0.53%)` | :arrow_up: |
   | hudisync | `54.05% <ø> (+2.31%)` | :arrow_up: |
   | huditimelineservice | `64.36% <ø> (ø)` | |
   | hudiutilities | `58.44% <ø> (+0.06%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | `5.99% <0.00%> (-0.07%)` | :arrow_down: |
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `36.36% <0.00%> (-1.74%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `16.96% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...g/apache/hudi/utilities/schema/SchemaProvider.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFQcm92aWRlci5qYXZh) | `71.42% <0.00%> (-28.58%)` | :arrow_down: |
   | [...e/hudi/sink/partitioner/profile/WriteProfiles.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL3BhcnRpdGlvbmVyL3Byb2ZpbGUvV3JpdGVQcm9maWxlcy5qYXZh) | `46.80% <0.00%> (-5.70%)` | :arrow_down: |
   | [...java/org/apache/hudi/sink/StreamWriteFunction.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL1N0cmVhbVdyaXRlRnVuY3Rpb24uamF2YQ==) | `81.06% <0.00%> (-3.78%)` | :arrow_down: |
   | [...src/main/scala/org/apache/hudi/DefaultSource.scala](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0RlZmF1bHRTb3VyY2Uuc2NhbGE=) | `75.22% <0.00%> (-2.23%)` | :arrow_down: |
   | ... and [49 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...f838764](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 641d1e6f0283b6476390a73594a75adde5f5cb9d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482) 
   * f838764919f2561ada6c9795f044106c9c338510 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b27bbd) into [master](https://codecov.io/gh/apache/hudi/commit/d07def12901485a9d59ab2b54602d535f00e5986?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d07def1) will **decrease** coverage by `32.03%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #3170       +/-   ##
   =============================================
   - Coverage     47.50%   15.47%   -32.04%     
   + Complexity     5430      479     -4951     
   =============================================
     Files           922      280      -642     
     Lines         40960    11564    -29396     
     Branches       4105      946     -3159     
   =============================================
   - Hits          19459     1789    -17670     
   + Misses        19779     9617    -10162     
   + Partials       1722      158     -1564     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `?` | |
   | hudiclient | `0.00% <0.00%> (-34.56%)` | :arrow_down: |
   | hudicommon | `?` | |
   | hudiflink | `?` | |
   | hudihadoopmr | `?` | |
   | hudisparkdatasource | `?` | |
   | hudisync | `5.38% <ø> (-48.67%)` | :arrow_down: |
   | huditimelineservice | `?` | |
   | hudiutilities | `58.05% <ø> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `0.00% <0.00%> (-72.98%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-42.79%)` | :arrow_down: |
   | [.../apache/hudi/keygen/constant/KeyGeneratorType.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9jb25zdGFudC9LZXlHZW5lcmF0b3JUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (-82.36%)` | :arrow_down: |
   | [...main/java/org/apache/hudi/metrics/HoodieGauge.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldHJpY3MvSG9vZGllR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/hudi/hive/NonPartitionedExtractor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvTm9uUGFydGl0aW9uZWRFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../java/org/apache/hudi/metrics/MetricsReporter.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldHJpY3MvTWV0cmljc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldHJpY3MvTWV0cmljc1JlcG9ydGVyVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rg/apache/hudi/client/bootstrap/BootstrapMode.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9ib290c3RyYXAvQm9vdHN0cmFwTW9kZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...he/hudi/hive/HiveStylePartitionValueExtractor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvSGl2ZVN0eWxlUGFydGl0aW9uVmFsdWVFeHRyYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [712 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d07def1...1b27bbd](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on a change in pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r662307168



##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java
##########
@@ -54,7 +59,12 @@ public static KeyGenerator createKeyGenerator(TypedProperties props) throws IOEx
   private static BuiltinKeyGenerator createKeyGeneratorByType(TypedProperties props) throws IOException {
     // Use KeyGeneratorType.SIMPLE as default keyGeneratorType
     String keyGeneratorType =
-        props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE_PROP.key(), KeyGeneratorType.SIMPLE.name());

Review comment:
       > Why do we need to refactor this? For adding a log message?
   
   Yes, to remind the user that they didn't set the key config, hudi use the default one




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=588",
       "triggerID" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff28cba39e0c88eb22406dabcad7e0517e6c2208",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=594",
       "triggerID" : "ff28cba39e0c88eb22406dabcad7e0517e6c2208",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1b27bbdc32805058bbbe137772a9785e0f86ef5d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=623",
       "triggerID" : "1b27bbdc32805058bbbe137772a9785e0f86ef5d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 55bcca83acc0817f05ff7e9962920c810d45cae0 UNKNOWN
   * a655c7156fa5933c677dffb97d721e1ff7f695be UNKNOWN
   * fc5dd253a3b19d4b3e1c3d48b167afd7d505d788 UNKNOWN
   * ff28cba39e0c88eb22406dabcad7e0517e6c2208 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=594) 
   * 1b27bbdc32805058bbbe137772a9785e0f86ef5d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=623) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869419748


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=482",
       "triggerID" : "641d1e6f0283b6476390a73594a75adde5f5cb9d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f838764919f2561ada6c9795f044106c9c338510",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=509",
       "triggerID" : "f838764919f2561ada6c9795f044106c9c338510",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=581",
       "triggerID" : "a17e1b1b9d6dee6db4b6e2005144a62d0f1e6004",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55bcca83acc0817f05ff7e9962920c810d45cae0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a655c7156fa5933c677dffb97d721e1ff7f695be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fc5dd253a3b19d4b3e1c3d48b167afd7d505d788",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=588",
       "triggerID" : "8aa96119c018eaa1c6faf5eb1b527c90cad8315c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 55bcca83acc0817f05ff7e9962920c810d45cae0 UNKNOWN
   * a655c7156fa5933c677dffb97d721e1ff7f695be UNKNOWN
   * fc5dd253a3b19d4b3e1c3d48b167afd7d505d788 UNKNOWN
   * 8aa96119c018eaa1c6faf5eb1b527c90cad8315c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=588) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on a change in pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r661320980



##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -353,14 +353,20 @@ private static int deduplicatePartitionPath(JavaSparkContext jsc, String duplica
 
   private static int doBootstrap(JavaSparkContext jsc, String tableName, String tableType, String basePath,
       String sourcePath, String recordKeyCols, String partitionFields, String parallelism, String schemaProviderClass,
-      String bootstrapIndexClass, String selectorClass, String keyGeneratorClass, String fullBootstrapInputProvider,
+      String bootstrapIndexClass, String selectorClass, String keyGenerator, String fullBootstrapInputProvider,
       String payloadClassName, String enableHiveSync, String propsFilePath, List<String> configs) throws IOException {
 
     TypedProperties properties = propsFilePath == null ? UtilHelpers.buildProperties(configs)
         : UtilHelpers.readConfig(FSUtils.getFs(propsFilePath, jsc.hadoopConfiguration()), new Path(propsFilePath), configs).getConfig();
 
     properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_BASE_PATH_PROP, sourcePath);
-    properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_KEYGEN_CLASS, keyGeneratorClass);
+    if (!StringUtils.isNullOrEmpty(keyGenerator)) {
+      if (keyGenerator.startsWith("org.apache.hudi")) {

Review comment:
       > Can we make sure, whether all the customized key generators start with `org.apache.hudi`?
   
   yes, they all start with `org.apache.hudi`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3170: [HUDI-1930] Bootstrap support configure KeyGenerator by type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#issuecomment-869465244


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3170](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f838764) into [master](https://codecov.io/gh/apache/hudi/commit/c08fbb4268ee4b227452fd27d5e6ba322eeef00e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c08fbb4) will **increase** coverage by `0.16%`.
   > The diff coverage is `18.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/3170/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3170      +/-   ##
   ============================================
   + Coverage     46.01%   46.18%   +0.16%     
   - Complexity     5306     5385      +79     
   ============================================
     Files           911      921      +10     
     Lines         39476    40045     +569     
     Branches       4254     4297      +43     
   ============================================
   + Hits          18166    18494     +328     
   - Misses        19456    19663     +207     
   - Partials       1854     1888      +34     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hudicli | `39.90% <0.00%> (-0.06%)` | :arrow_down: |
   | hudiclient | `30.43% <22.22%> (-0.01%)` | :arrow_down: |
   | hudicommon | `47.56% <ø> (+<0.01%)` | :arrow_up: |
   | hudiflink | `60.06% <ø> (-1.27%)` | :arrow_down: |
   | hudihadoopmr | `51.29% <ø> (ø)` | |
   | hudisparkdatasource | `67.06% <ø> (+0.53%)` | :arrow_up: |
   | hudisync | `54.05% <ø> (+2.31%)` | :arrow_up: |
   | huditimelineservice | `64.36% <ø> (ø)` | |
   | hudiutilities | `58.40% <ø> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | `5.99% <0.00%> (-0.07%)` | :arrow_down: |
   | [.../org/apache/hudi/config/HoodieBootstrapConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVCb290c3RyYXBDb25maWcuamF2YQ==) | `36.36% <0.00%> (-1.74%)` | :arrow_down: |
   | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `16.96% <0.00%> (-0.04%)` | :arrow_down: |
   | [.../bootstrap/SparkBootstrapCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2Jvb3RzdHJhcC9TcGFya0Jvb3RzdHJhcENvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../keygen/factory/HoodieAvroKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2tleWdlbi9mYWN0b3J5L0hvb2RpZUF2cm9LZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...keygen/factory/HoodieSparkKeyGeneratorFactory.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL2ZhY3RvcnkvSG9vZGllU3BhcmtLZXlHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <40.00%> (-10.93%)` | :arrow_down: |
   | [...g/apache/hudi/utilities/schema/SchemaProvider.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFQcm92aWRlci5qYXZh) | `71.42% <0.00%> (-28.58%)` | :arrow_down: |
   | [...e/hudi/sink/partitioner/profile/WriteProfiles.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL3BhcnRpdGlvbmVyL3Byb2ZpbGUvV3JpdGVQcm9maWxlcy5qYXZh) | `46.80% <0.00%> (-5.70%)` | :arrow_down: |
   | [...java/org/apache/hudi/sink/StreamWriteFunction.java](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9zaW5rL1N0cmVhbVdyaXRlRnVuY3Rpb24uamF2YQ==) | `81.06% <0.00%> (-3.78%)` | :arrow_down: |
   | [...src/main/scala/org/apache/hudi/DefaultSource.scala](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0RlZmF1bHRTb3VyY2Uuc2NhbGE=) | `75.22% <0.00%> (-2.23%)` | :arrow_down: |
   | ... and [50 more](https://codecov.io/gh/apache/hudi/pull/3170/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c08fbb4...f838764](https://codecov.io/gh/apache/hudi/pull/3170?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org