You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Colin Chalmers <co...@maxware.nl> on 2003/06/18 09:13:51 UTC

IntakeService PATCH?

Hi all,

I have a number of patches for the IntakeService which I would like to have
included in the next release (2.3). I sent a couple of Zip files to Henning
about 1.5 weeks ago but I think he's too busy with his day job to peruse the
patches and either check them in or kick them back to me for changes :-)

Could another committer do this? If so, how would you like the patches?
Zips?

Colin


---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org


Re: IntakeService PATCH?

Posted by Colin Chalmers <co...@maxware.nl>.
Sure, I'll get the changes written up tomorrow.

Eric, Yes I'll be adapting the current HOW-TO to the new situation.

Colin

----- Original Message ----- 
From: "Quinton McCombs" <qm...@nequalsone.com>
To: "'Turbine Developers List'" <tu...@jakarta.apache.org>
Sent: Thursday, June 19, 2003 6:06 PM
Subject: RE: IntakeService PATCH?


> Colin,
>   Could you also submit a patch for xdoc/changes.xml?  Just put
> something in there describing the changes to intake.
> 
> --------------------------------------------
> Quinton McCombs
> NequalsOne - HealthCare marketing tools
> mailto:qmccombs@NequalsOne.com
> http://www.NequalsOne.com 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org


RE: IntakeService PATCH?

Posted by Quinton McCombs <qm...@nequalsone.com>.
Colin,
  Could you also submit a patch for xdoc/changes.xml?  Just put
something in there describing the changes to intake.

--------------------------------------------
Quinton McCombs
NequalsOne - HealthCare marketing tools
mailto:qmccombs@NequalsOne.com
http://www.NequalsOne.com 


---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org


RE: IntakeService PATCH?

Posted by Colin Chalmers <co...@maxware.nl>.
Sorry, thought it was obvious from other comments & discussions, I'll pay
more attention next time.

Colin

-----Original Message-----
From: Henning P. Schmiedehausen [mailto:hps@intermeta.de]
Sent: Thursday, June 19, 2003 4:14 PM
To: turbine-dev@jakarta.apache.org
Subject: Re: IntakeService PATCH?


"Colin Chalmers" <co...@maxware.nl> writes:

I'm currently working on this.

Colin, if you _ever_ want to get patches attached in a faster manner, please
pull out the current HEAD tree in a separate directory and then do

diff -Nurb --exclude=CVS dir-of-current-head dir-of-your-modified tree

Sending me dozens of files without directory hierarchy and single
patches didn't exactly cut down the time that I needed to apply the
patches and so they had to wait until I found the time to apply the
stuff.

	Regards
		Henning

--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/

Java, perl, Solaris, Linux, xSP Consulting, Web Services
freelance consultant -- Jakarta Turbine Development  -- hero for hire

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org


Re: IntakeService PATCH?

Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
"Colin Chalmers" <co...@maxware.nl> writes:

I'm currently working on this.

Colin, if you _ever_ want to get patches attached in a faster manner, please
pull out the current HEAD tree in a separate directory and then do

diff -Nurb --exclude=CVS dir-of-current-head dir-of-your-modified tree

Sending me dozens of files without directory hierarchy and single
patches didn't exactly cut down the time that I needed to apply the
patches and so they had to wait until I found the time to apply the
stuff.

	Regards
		Henning

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/

Java, perl, Solaris, Linux, xSP Consulting, Web Services 
freelance consultant -- Jakarta Turbine Development  -- hero for hire

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org


Re: IntakeService PATCH?

Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
"Colin Chalmers" <co...@maxware.nl> writes:

>Could another committer do this? If so, how would you like the patches?
>Zips?

.. having DOS line-endings, tabs and non-Apache style indentation didn't
exactly help your code either. ;-)

Next time, please read the Turbine Coding guidelines. 

	Regards
		Henning
-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/

Java, perl, Solaris, Linux, xSP Consulting, Web Services 
freelance consultant -- Jakarta Turbine Development  -- hero for hire

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org