You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/08/20 06:48:35 UTC
[GitHub] zeppelin pull request #3152: [ZEPPELIN-3736] Helium page's UI to show loadin...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3152
[ZEPPELIN-3736] Helium page's UI to show loading screen
### What is this PR for?
At times Helium page's API takes time to return the result, the idea of this JIRA is to show a loading screen while it takes time.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [ZEPPELIN-3736](https://issues.apache.org/jira/browse/ZEPPELIN-3736)
### How should this be tested?
* Refer screen shot
### Screenshots (if appropriate)
Before:
![before](https://user-images.githubusercontent.com/674497/44323377-458d1880-a46f-11e8-8377-22ae340a45c1.gif)
After:
![after](https://user-images.githubusercontent.com/674497/44323376-458d1880-a46f-11e8-9aeb-b7557c3df183.gif)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3736
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3152
----
commit e4f4b9894002f02a197b413d987c74f54fdf02d0
Author: Prabhjyot Singh <pr...@...>
Date: 2018-08-20T06:19:10Z
loading screen in helium page
Change-Id: I9156f8ad60128dc4b1a5005c4d81098b81c47905
----
---
[GitHub] zeppelin issue #3152: [ZEPPELIN-3736] Helium page's UI to show loading scree...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3152
It takes about 2-3 seconds every time, about same time as in the screen shot above.
---
[GitHub] zeppelin issue #3152: [ZEPPELIN-3736] Helium page's UI to show loading scree...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3152
Any reason why helium response slowly ?
---
[GitHub] zeppelin issue #3152: [ZEPPELIN-3736] Helium page's UI to show loading scree...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3152
Possibly because `/api/helium/package` API checks for both local and remote (by default configure to https://s3.amazonaws.com/helium-package/helium.json) helium.json.
---
[GitHub] zeppelin issue #3152: [ZEPPELIN-3736] Helium page's UI to show loading scree...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3152
Then it seems a bug to me.
---
[GitHub] zeppelin pull request #3152: [ZEPPELIN-3736] Helium page's UI to show loadin...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/3152
---
[GitHub] zeppelin issue #3152: [ZEPPELIN-3736] Helium page's UI to show loading scree...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3152
I guess it is only for the first time, After that, helium packages info should be cached in zeppelin server, right ?
---
[GitHub] zeppelin issue #3152: [ZEPPELIN-3736] Helium page's UI to show loading scree...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3152
Update:
Option 2 that can be used alternatively over here:
![option2](https://user-images.githubusercontent.com/674497/44325705-272b1b00-a477-11e8-9c2a-c2ca1cc2eb8d.gif)
---