You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by foxish <gi...@git.apache.org> on 2018/05/09 17:32:02 UTC

[GitHub] spark pull request #21238: [SPARK-24137][K8s] Mount local directories as emp...

Github user foxish commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21238#discussion_r187116886
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -455,7 +455,8 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging with Seria
       private[spark] def validateSettings() {
         if (contains("spark.local.dir")) {
           val msg = "In Spark 1.0 and later spark.local.dir will be overridden by the value set by " +
    -        "the cluster manager (via SPARK_LOCAL_DIRS in mesos/standalone and LOCAL_DIRS in YARN)."
    +        "the cluster manager (via SPARK_LOCAL_DIRS in mesos/standalone/kubernetes and LOCAL_DIRS" +
    --- End diff --
    
    oops, I deleted a comment here accidentally. @rxin said that we could remove this warning about Spark 1.0.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org