You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/06/05 04:46:41 UTC
[GitHub] [kylin] codecov-io commented on issue #674: KYLIN-3271 KYLIN-3454
minor refactor, accelerate ResourceTool
codecov-io commented on issue #674: KYLIN-3271 KYLIN-3454 minor refactor, accelerate ResourceTool
URL: https://github.com/apache/kylin/pull/674#issuecomment-498936878
# [Codecov](https://codecov.io/gh/apache/kylin/pull/674?src=pr&el=h1) Report
> Merging [#674](https://codecov.io/gh/apache/kylin/pull/674?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/c3a71101286ba994dec85aa515236b28c98b9e94?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `62.5%`.
[](https://codecov.io/gh/apache/kylin/pull/674?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #674 +/- ##
============================================
+ Coverage 25.77% 25.78% +<.01%
+ Complexity 6008 6006 -2
============================================
Files 1382 1382
Lines 82201 82196 -5
Branches 11518 11516 -2
============================================
+ Hits 21190 21193 +3
+ Misses 58962 58959 -3
+ Partials 2049 2044 -5
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/674?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/kylin/common/persistence/ResourceTool.java](https://codecov.io/gh/apache/kylin/pull/674/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVRvb2wuamF2YQ==) | `20.83% <62.5%> (-1.72%)` | `13 <1> (-1)` | |
| [...apache/kylin/common/persistence/ResourceStore.java](https://codecov.io/gh/apache/kylin/pull/674/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVN0b3JlLmphdmE=) | `71.94% <0%> (-1%)` | `54% <0%> (-2%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/674/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.91%)` | `7% <0%> (ø)` | :arrow_down: |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/674/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/674/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `51.16% <0%> (+2.32%)` | `8% <0%> (+1%)` | :arrow_up: |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/674/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `76.74% <0%> (+2.32%)` | `12% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/674?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/674?src=pr&el=footer). Last update [c3a7110...5d53a70](https://codecov.io/gh/apache/kylin/pull/674?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services