[GitHub] [lucene-solr] jpountz commented on issue #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

[GitBox <gi...@apache.org>]

jpountz commented on issue #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/916#issuecomment-552612881
 
 
   @atris I tried to build a test case for the above case:
   
   ```java
     public void testAsyncCachingHitsClosedReader() throws Exception {
       Directory dir = newDirectory();
       final RandomIndexWriter w = new RandomIndexWriter(random(), dir);
       Document doc = new Document();
       doc.add(new StringField("color", "red", Store.NO));
       w.addDocument(doc);
       IndexReader reader = w.getReader();
       w.close();
   
       // Because our index has a single document, it also has a single segment. In that
       // case, IndexSearcher will use the current thread for searching, so the only thing
       // that runs via the executor is the caching of queries.
       final CountDownLatch[] awaitCaching = new CountDownLatch[1];
       awaitCaching[0] = new CountDownLatch(1);
       final CountDownLatch[] cachingRan = new CountDownLatch[1];
       cachingRan[0] = new CountDownLatch(1);
       final AtomicBoolean success = new AtomicBoolean(false);
       Executor executor = runnable -> {
         new Thread(() -> {
           try {
             awaitCaching[0].await();
             runnable.run();
             success.set(true);
           } catch (InterruptedException e) {
             Thread.currentThread().interrupt();
           } finally {
             cachingRan[0].countDown();
           }
         }).start();      
       };
   
       final IndexSearcher searcher = new IndexSearcher(reader, executor);
       final LRUQueryCache queryCache = new LRUQueryCache(2, 100000, context -> true);
       searcher.setQueryCache(queryCache);
       searcher.setQueryCachingPolicy(ALWAYS_CACHE);
   
       searcher.search(new ConstantScoreQuery(new TermQuery(new Term("color", "red"))), 1);
       assertEquals(Collections.emptyList(), queryCache.cachedQueries());
       awaitCaching[0].countDown();
       cachingRan[0].await();
       assertTrue(success.get());
       assertEquals(Collections.singletonList(new TermQuery(new Term("color", "red"))), queryCache.cachedQueries());
   
       awaitCaching[0] = new CountDownLatch(1);
       cachingRan[0] = new CountDownLatch(1);
       success.set(false);
       queryCache.clear();
   
       searcher.search(new ConstantScoreQuery(new TermQuery(new Term("color", "red"))), 1);
       assertEquals(Collections.emptyList(), queryCache.cachedQueries());
       reader.close();
       awaitCaching[0].countDown();
       cachingRan[0].await();
       assertTrue(success.get());
       assertEquals(Collections.emptyList(), queryCache.cachedQueries());
   
       dir.close();
     }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org