You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "zhfeng (via GitHub)" <gi...@apache.org> on 2023/05/09 02:01:13 UTC

[GitHub] [shardingsphere-elasticjob] zhfeng opened a new pull request, #2216: Upgrade snakeyaml to 2.0 and springboot to 2.7.10

zhfeng opened a new pull request, #2216:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2216

   Fixes #I2215.
   
   Changes proposed in this pull request:
   - Upgrade snakeyaml 2.0
   - springboot 2.7.10
   - spring 5.3.26
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] zhfeng commented on pull request #2216: Upgrade snakeyaml to 2.0 and springboot to 2.7.10

Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #2216:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2216#issuecomment-1647496265

   I think we have to wait `3.0.4` release and upgrade in shardingsphere?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #2216: Upgrade snakeyaml to 2.0 and springboot to 2.7.10

Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN merged PR #2216:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] copbint commented on pull request #2216: Upgrade snakeyaml to 2.0 and springboot to 2.7.10

Posted by "copbint (via GitHub)" <gi...@apache.org>.
copbint commented on PR #2216:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2216#issuecomment-1647537219

   Thanks for your work. We are also waiting for `3.0.4`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] copbint commented on pull request #2216: Upgrade snakeyaml to 2.0 and springboot to 2.7.10

Posted by "copbint (via GitHub)" <gi...@apache.org>.
copbint commented on PR #2216:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2216#issuecomment-1617089687

   Hello, can we make some progress on this, we need it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] zhfeng commented on pull request #2216: Upgrade snakeyaml to 2.0 and springboot to 2.7.10

Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #2216:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2216#issuecomment-1549611638

   @TeslaCN can you take a review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #2216: Upgrade snakeyaml to 2.0 and springboot to 2.7.10

Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on PR #2216:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2216#issuecomment-1647274723

   Sorry for the delay. Thank you @zhfeng .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] hanyongchao007 commented on pull request #2216: Upgrade snakeyaml to 2.0 and springboot to 2.7.10

Posted by "hanyongchao007 (via GitHub)" <gi...@apache.org>.
hanyongchao007 commented on PR #2216:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2216#issuecomment-1647492559

   the current vesion  of shardingsphere, Which version do I need to upgrade @TeslaCN 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #2216: Upgrade snakeyaml to 2.0 and springboot to 2.7.10

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2216:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2216#issuecomment-1539296749

   ## [Codecov](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2216?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2216](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2216?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56a6039) into [master](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/commit/a7042cf4872d784d619e4560cdfa0f92b0311965?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a7042cf) will **decrease** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2216      +/-   ##
   ============================================
   - Coverage     84.68%   84.67%   -0.01%     
     Complexity     1928     1928              
   ============================================
     Files           287      287              
     Lines          6314     6317       +3     
     Branches        700      700              
   ============================================
   + Hits           5347     5349       +2     
     Misses          646      646              
   - Partials        321      322       +1     
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ardingsphere/elasticjob/infra/yaml/YamlEngine.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS95YW1sL1lhbWxFbmdpbmUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...ra/yaml/representer/ElasticJobYamlRepresenter.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS95YW1sL3JlcHJlc2VudGVyL0VsYXN0aWNKb2JZYW1sUmVwcmVzZW50ZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   
   ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2216/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org