[GitHub] [incubator-kyuubi] zhouyifan279 commented on a change in pull request #1438: Respect kyuubi.authentication

[GitBox <gi...@apache.org>]

zhouyifan279 commented on a change in pull request #1438:
URL: https://github.com/apache/incubator-kyuubi/pull/1438#discussion_r759839392



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionManager.scala
##########
@@ -36,7 +37,9 @@ class KyuubiSessionManager private (name: String) extends SessionManager(name) {
   val credentialsManager = new HadoopCredentialsManager()
 
   override def initialize(conf: KyuubiConf): Unit = {
-    addService(credentialsManager)
+    if (UserGroupInformation.isSecurityEnabled) {
+      addService(credentialsManager)
+    }

Review comment:
       This `if` statement should be placed in `HadoopCredentialsManager#initialize` like how we do in `KinitAuxiliaryService#initialize`. 
   Otherwise, we will use an uninitialized `HadoopCredentialsManager`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org