You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2013/11/11 14:51:17 UTC
[jira] [Commented] (LUCENE-5337) Add Payload support to
FileDictionary (Suggest) and make it more configurable
[ https://issues.apache.org/jira/browse/LUCENE-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818969#comment-13818969 ]
Erick Erickson commented on LUCENE-5337:
----------------------------------------
Areek:
There are a couple of problems with this patch...
1> It won't compile in 4x since it uses some Java 7 constructs,
I stopped at the "diamond" bit. Unless this is intended for trunk only, could you fix these?
2> on trunk, running "ant precommit" shows the following errors. These are pretty easy to fix, just takes specifying the UTF-8 charset as I remember. They're all in the test code, but still....
[forbidden-apis] Reading bundled API signatures: jdk-unsafe-1.7
[forbidden-apis] Reading bundled API signatures: jdk-deprecated-1.7
[forbidden-apis] Reading API signatures: /Users/Erick/apache/trunk_5337/lucene/tools/forbiddenApis/base.txt
[forbidden-apis] Loading classes to check...
[forbidden-apis] Scanning for API signatures and dependencies...
[forbidden-apis] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset]
[forbidden-apis] in org.apache.lucene.search.suggest.FileDictionaryTest (FileDictionaryTest.java:76)
[forbidden-apis] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset]
[forbidden-apis] in org.apache.lucene.search.suggest.FileDictionaryTest (FileDictionaryTest.java:98)
[forbidden-apis] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset]
[forbidden-apis] in org.apache.lucene.search.suggest.FileDictionaryTest (FileDictionaryTest.java:120)
[forbidden-apis] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset]
[forbidden-apis] in org.apache.lucene.search.suggest.FileDictionaryTest (FileDictionaryTest.java:146)
[forbidden-apis] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset]
[forbidden-apis] in org.apache.lucene.search.suggest.FileDictionaryTest (FileDictionaryTest.java:173)
[forbidden-apis] Scanned 179 (and 405 related) class file(s) for forbidden API invocations (in 0.10s), 5 error(s).
I can take care of the secretarial stuff here and get this committed. I glanced over the code but don't know the area deeply to make any deeper comments, anyone want to chime in on that score?
> Add Payload support to FileDictionary (Suggest) and make it more configurable
> -----------------------------------------------------------------------------
>
> Key: LUCENE-5337
> URL: https://issues.apache.org/jira/browse/LUCENE-5337
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Areek Zillur
> Attachments: LUCENE-5337.patch
>
>
> It would be nice to add payload support to FileDictionary, so user can pass in associated payload with suggestion entries.
> Currently the FileDictionary has a hard-coded field-delimiter (TAB), it would be nice to let the users configure the field delimiter as well.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org