You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2013/04/30 00:37:27 UTC

svn commit: r1477393 - /subversion/trunk/build/generator/gen_base.py

Author: danielsh
Date: Mon Apr 29 22:37:26 2013
New Revision: 1477393

URL: http://svn.apache.org/r1477393
Log:
Note a limitation of a maintainer-mode feature.

* build/generator/gen_base.py
  (GeneratorBase.write_errno_table): Add comment pointing out a limitation.

Modified:
    subversion/trunk/build/generator/gen_base.py

Modified: subversion/trunk/build/generator/gen_base.py
URL: http://svn.apache.org/viewvc/subversion/trunk/build/generator/gen_base.py?rev=1477393&r1=1477392&r2=1477393&view=diff
==============================================================================
--- subversion/trunk/build/generator/gen_base.py (original)
+++ subversion/trunk/build/generator/gen_base.py Mon Apr 29 22:37:26 2013
@@ -241,6 +241,13 @@ class GeneratorBase:
 
   @staticmethod
   def write_errno_table():
+    # ### We generate errorcode.inc at autogen.sh time (here!).
+    # ###
+    # ### Currently it's only used by maintainer-mode builds.  If this
+    # ### functionality ever moves to release builds, it will have to move
+    # ### to configure-time.  (But then you have to solve two problems:
+    # ### what to do on windows, and what to do on unix when Python is not
+    # ### available at configure-time.)
     import errno
     fd = open('subversion/libsvn_subr/errorcode.inc', 'w')
     fd.write('/* This file was generated by build/generator/gen_base.py */\n\n')