You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "wolfboys (via GitHub)" <gi...@apache.org> on 2023/03/01 04:03:58 UTC
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2379: Streampark flink job package includes cliassifier packages
wolfboys commented on code in PR #2379:
URL: https://github.com/apache/incubator-streampark/pull/2379#discussion_r1121111594
##########
streampark-console/streampark-console-webapp/src/views/flink/app/components/Dependency.vue:
##########
@@ -113,12 +116,15 @@
}
}
if (invalidArtifact.length === 0) {
- const id = groupId + '_' + artifactId;
+ const id = classifier != null ? groupId + '_' + artifactId + '_' + classifier : groupId + '_' + artifactId;
Review Comment:
I suggest add a new method for this
##########
streampark-console/streampark-console-webapp/src/views/flink/app/components/Dependency.vue:
##########
@@ -220,7 +226,7 @@
handleUpdateDependency();
}
function handleRemovePom(pom: Recordable) {
- const id = pom.groupId + '_' + pom.artifactId;
+ const id = pom.classifier != null ? pom.groupId + '_' + pom.artifactId + '_' + pom.classifier : pom.groupId + '_' + pom.artifactId;
Review Comment:
repeated logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org