You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/20 13:54:53 UTC

[GitHub] [spark] grundprinzip commented on pull request #39078: [SPARK-41534][CONNECT][SQL] Setup initial client module for Spark Connect

grundprinzip commented on PR #39078:
URL: https://github.com/apache/spark/pull/39078#issuecomment-1359395029

   Generally, I'm fine with merging and iterating from here. However, one last question to @hvanhovell and @vicennial. Can you please move the client into a subdirectory of `connector/connect/client/scala/` rather than in the generic client directory. This gives more room for other clients to find their place.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org