[jira] [Commented] (OFBIZ-6488) Replace facility/control/EditFacility with widgets

["Pierre Smits (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578467#comment-14578467 ] 

Pierre Smits commented on OFBIZ-6488:
-------------------------------------

Hi Christian,

I did a cursory review of your patch. I see following:
{code}
<field name="facilityName" tooltip="${uiLabelMap.CommonRequired}"><text/></field>
{code}
In stead of using a tooltip to indicate that a field is required to be filled out, it is better to put validation in place, like:
{code}
<field name="facilityName" required-field="true"><text/></field>
{code}

And I would lose the tooltip on field facilityId.

> Replace facility/control/EditFacility with widgets
> --------------------------------------------------
>
>                 Key: OFBIZ-6488
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6488
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Christian Carlow
>            Priority: Minor
>         Attachments: OFBIZ-6488.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)