You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2025/09/02 16:22:58 UTC
[PR] chore: Remove the deprecated onDownstreamFinish method in GraphStage [pekko]
He-Pin opened a new pull request, #2129:
URL: https://github.com/apache/pekko/pull/2129
Motivation:
This method should and can be removed completely, it was deprecated.
Modification:
Remvoe the private onDownstreamFinish method
Result:
Clean code and better performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Remove the deprecated onDownstreamFinish method in GraphStage [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #2129:
URL: https://github.com/apache/pekko/pull/2129#discussion_r2316601323
##########
stream/src/main/scala/org/apache/pekko/stream/stage/GraphStage.scala:
##########
@@ -699,10 +698,6 @@ abstract class GraphStageLogic private[stream] (val inCount: Int, val outCount:
// Variable used from `OutHandler.onDownstreamFinish` to carry over cancellation cause in cases where
Review Comment:
can you remove this comment and next line too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Remove the deprecated onDownstreamFinish method in GraphStage [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #2129:
URL: https://github.com/apache/pekko/pull/2129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org