You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Kevin kalmbach (JIRA)" <ji...@apache.org> on 2008/01/23 18:01:24 UTC

[jira] Created: (SM-1204) add jbi extension support in saxon component

add jbi extension support in saxon component
--------------------------------------------

                 Key: SM-1204
                 URL: https://issues.apache.org/activemq/browse/SM-1204
             Project: ServiceMix
          Issue Type: Improvement
          Components: servicemix-saxon
    Affects Versions: 3.2.1
         Environment: all
            Reporter: Kevin kalmbach
         Attachments: saxon.zip

In the lw container there were jbi extensions for xalan xsl transformations.
We would like this functionality reproduced in the Saxon transformers.

I attached all new files.
The only change to xsl files is that in the header, there needs to be this line.. (indicating the class for the extensions).
<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
	xmlns:jbi="saxon://org.apache.servicemix.saxon.JBIExtension"
        extension-element-prefixes="jbi"
>


Also in XsltEndpoint.java (Both in saxon and xalan), at the bottom of the file, there are sets for in, exchange and component.
out needs to be set here as well (This looks like an old bug even from the xalan days).  This is needed for setProperties and copyOut.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1204) add jbi extension support in saxon component

Posted by "Kevin kalmbach (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41206#action_41206 ] 

Kevin kalmbach commented on SM-1204:
------------------------------------

All of the files in the zip are new files (nothing to diff against).  Do I
need to do anything for that?

For changes I want in the XsltEndpoints, I will add in the svn diffs (not
sure when I will get around to it, hopefully next week).

For the ASF header, is there a template for that (or just copy it from
anywhere)?.  Do I need to add that in myself or can I just giver permission
for someone else to add it in?.

For the junit, I'm not sure how to write one that goes against an endpoint.
Do you have any tutorials/etc for writing a junit test case against a
servicemix component?

(In case you can't tell) I'm new to this submitting stuff, so if these are
dumb questions, forgive me.
-Kevin






> add jbi extension support in saxon component
> --------------------------------------------
>
>                 Key: SM-1204
>                 URL: https://issues.apache.org/activemq/browse/SM-1204
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-saxon
>    Affects Versions: 3.2.1
>         Environment: all
>            Reporter: Kevin kalmbach
>         Attachments: saxon.zip
>
>   Original Estimate: 2 days
>  Remaining Estimate: 2 days
>
> In the lw container there were jbi extensions for xalan xsl transformations.
> We would like this functionality reproduced in the Saxon transformers.
> I attached all new files.
> The only change to xsl files is that in the header, there needs to be this line.. (indicating the class for the extensions).
> <xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
> 	xmlns:jbi="saxon://org.apache.servicemix.saxon.JBIExtension"
>         extension-element-prefixes="jbi"
> >
> Also in XsltEndpoint.java (Both in saxon and xalan), at the bottom of the file, there are sets for in, exchange and component.
> out needs to be set here as well (This looks like an old bug even from the xalan days).  This is needed for setProperties and copyOut.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1204) add jbi extension support in saxon component

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41183#action_41183 ] 

Guillaume Nodet commented on SM-1204:
-------------------------------------

Would it be possible to provide the patch as a 'svn diff' ?
It makes it far easier to review and apply.
Also, make sure the java files all have the correct ASF header.

If you have more time, a very simple junit test case would be awesome
and that would give an idea how to configure the xslt to leverage these
extensions (in addition to making sure it works).

> add jbi extension support in saxon component
> --------------------------------------------
>
>                 Key: SM-1204
>                 URL: https://issues.apache.org/activemq/browse/SM-1204
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-saxon
>    Affects Versions: 3.2.1
>         Environment: all
>            Reporter: Kevin kalmbach
>         Attachments: saxon.zip
>
>   Original Estimate: 2 days
>  Remaining Estimate: 2 days
>
> In the lw container there were jbi extensions for xalan xsl transformations.
> We would like this functionality reproduced in the Saxon transformers.
> I attached all new files.
> The only change to xsl files is that in the header, there needs to be this line.. (indicating the class for the extensions).
> <xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
> 	xmlns:jbi="saxon://org.apache.servicemix.saxon.JBIExtension"
>         extension-element-prefixes="jbi"
> >
> Also in XsltEndpoint.java (Both in saxon and xalan), at the bottom of the file, there are sets for in, exchange and component.
> out needs to be set here as well (This looks like an old bug even from the xalan days).  This is needed for setProperties and copyOut.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SM-1204) add jbi extension support in saxon component

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/SM-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41525#action_41525 ] 

Guillaume Nodet commented on SM-1204:
-------------------------------------

Usually, the way to create a good patch is the following:
   * check out the sources using svn
   * modify the sources as needed
   * svn add all the new files
   * use svn diff to create a patch
   
For junit, there are already some tests in the component that you can look at.  
There is no real guide, but looking at the existing is usually a good way to learn. 

> add jbi extension support in saxon component
> --------------------------------------------
>
>                 Key: SM-1204
>                 URL: https://issues.apache.org/activemq/browse/SM-1204
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-saxon
>    Affects Versions: 3.2.1
>         Environment: all
>            Reporter: Kevin kalmbach
>         Attachments: saxon.zip
>
>   Original Estimate: 2 days
>  Remaining Estimate: 2 days
>
> In the lw container there were jbi extensions for xalan xsl transformations.
> We would like this functionality reproduced in the Saxon transformers.
> I attached all new files.
> The only change to xsl files is that in the header, there needs to be this line.. (indicating the class for the extensions).
> <xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
> 	xmlns:jbi="saxon://org.apache.servicemix.saxon.JBIExtension"
>         extension-element-prefixes="jbi"
> >
> Also in XsltEndpoint.java (Both in saxon and xalan), at the bottom of the file, there are sets for in, exchange and component.
> out needs to be set here as well (This looks like an old bug even from the xalan days).  This is needed for setProperties and copyOut.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.