You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "RaigorJiang (via GitHub)" <gi...@apache.org> on 2023/03/12 17:02:35 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #24568: Fix TODO in ProxyBackendHandler and QueryableRALBackendHandler.

RaigorJiang opened a new pull request, #24568:
URL: https://github.com/apache/shardingsphere/pull/24568

   Fixes #24181.
   
   Fix TODO in ProxyBackendHandler and QueryableRALBackendHandler.
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #24568: Fix TODO in ProxyBackendHandler and QueryableRALBackendHandler.

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24568:
URL: https://github.com/apache/shardingsphere/pull/24568#issuecomment-1465256094

   ## [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#24568](https://codecov.io/gh/apache/shardingsphere/pull/24568?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d5e1cd) into [master](https://codecov.io/gh/apache/shardingsphere/commit/95f2035d7703b5c35e0503d0d5ff2c95303bac01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95f2035) will **decrease** coverage by `0.01%`.
   > The diff coverage is `53.33%`.
   
   > :exclamation: Current head 7d5e1cd differs from pull request most recent head b5fc1f5. Consider uploading reports for the commit b5fc1f5 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #24568      +/-   ##
   ============================================
   - Coverage     50.00%   50.00%   -0.01%     
     Complexity     1595     1595              
   ============================================
     Files          3311     3310       -1     
     Lines         54047    54044       -3     
     Branches       9942     9942              
   ============================================
   - Hits          27026    27023       -3     
     Misses        24605    24605              
     Partials       2416     2416              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...tsql/ral/UpdatableGlobalRuleRALBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2hhbmRsZXIvZGlzdHNxbC9yYWwvVXBkYXRhYmxlR2xvYmFsUnVsZVJBTEJhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...andler/distsql/ral/UpdatableRALBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2hhbmRsZXIvZGlzdHNxbC9yYWwvVXBkYXRhYmxlUkFMQmFja2VuZEhhbmRsZXIuamF2YQ==) | `60.00% <ø> (ø)` | |
   | [.../handler/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2hhbmRsZXIvZGlzdHNxbC9yYWwvUkFMQmFja2VuZEhhbmRsZXJGYWN0b3J5LmphdmE=) | `60.00% <50.00%> (ø)` | |
   | [...andler/distsql/ral/QueryableRALBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2hhbmRsZXIvZGlzdHNxbC9yYWwvUXVlcnlhYmxlUkFMQmFja2VuZEhhbmRsZXIuamF2YQ==) | `51.42% <60.00%> (+1.42%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tristaZero merged pull request #24568: Fix TODO in RALBackendHandlerFactory and QueryableRALBackendHandler.

Posted by "tristaZero (via GitHub)" <gi...@apache.org>.
tristaZero merged PR #24568:
URL: https://github.com/apache/shardingsphere/pull/24568


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org