You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by amihalik <gi...@git.apache.org> on 2016/10/17 19:35:36 UTC
[GitHub] incubator-rya pull request #115: RYA-200 Removing findbugs:jsr305 Dependency
GitHub user amihalik opened a pull request:
https://github.com/apache/incubator-rya/pull/115
RYA-200 Removing findbugs:jsr305 Dependency
## Description
Removed findbugs:jsr305 Dependency. Replaced with findbugs-annotations.
Several annotations are not available in findbugs-annotations. These annotations where commented out and a new JIRA ticket (RYA-211) was created to deal with them:
- @ThreadSafe
- @Immutable
- @ParametersAreNonnullByDefault
### Tests
Current tests pass. No New tests.
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-200)
### Checklist
- [ ] Code Review
- [ ] Squash Commits
#### People To Reivew
@isper3at
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amihalik/incubator-rya RYA-200
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit 13af4d4976a498db8c682d919d5b63fdb6528a98
Author: Aaron Mihalik <mi...@alum.mit.edu>
Date: 2016-10-17T19:20:39Z
RYA-200 Removing findbugs:jsr305 Dependency
Closes #115
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on the issue:
https://github.com/apache/incubator-rya/pull/115
@joshelser thanks a lot for finding those libraries and reading the docs in detail to find the equivalent to ParametersAreNonNullByDefault.
I've updated the PR with your findings, and if there are no more comments, I'll pull it into master tomorrow. (Note that the Jenkins failure is the result of some test failures that I've fixing in another PR).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rya/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/115#discussion_r83735217
--- Diff: extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/StatementPatternMetadata.java ---
@@ -20,9 +20,9 @@
import static com.google.common.base.Preconditions.checkNotNull;
-import javax.annotation.Nullable;
-import javax.annotation.ParametersAreNonnullByDefault;
-import javax.annotation.concurrent.Immutable;
+import edu.umd.cs.findbugs.annotations.Nullable;
--- End diff --
pong
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/115#discussion_r83734972
--- Diff: extras/rya.console/src/main/java/org/apache/rya/shell/SharedShellState.java ---
@@ -23,10 +23,10 @@
import java.util.Objects;
import java.util.concurrent.locks.ReentrantLock;
-import javax.annotation.Nullable;
-import javax.annotation.ParametersAreNonnullByDefault;
-import javax.annotation.concurrent.Immutable;
-import javax.annotation.concurrent.ThreadSafe;
+import edu.umd.cs.findbugs.annotations.Nullable;
--- End diff --
hurmmm? this intentional?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/115#discussion_r83735110
--- Diff: extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/FilterMetadata.java ---
@@ -21,9 +21,9 @@
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkNotNull;
-import javax.annotation.Nullable;
-import javax.annotation.ParametersAreNonnullByDefault;
-import javax.annotation.concurrent.Immutable;
+import edu.umd.cs.findbugs.annotations.Nullable;
--- End diff --
Here too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/115#discussion_r83735136
--- Diff: extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/FluoQuery.java ---
@@ -25,9 +25,9 @@
import java.util.Map;
import java.util.Map.Entry;
-import javax.annotation.Nullable;
-import javax.annotation.ParametersAreNonnullByDefault;
-import javax.annotation.concurrent.Immutable;
+import edu.umd.cs.findbugs.annotations.Nullable;
--- End diff --
and here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/incubator-rya/pull/115
ThreadSafe and Immutable are available in https://github.com/stephenc/jcip-annotations
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/115#discussion_r83735054
--- Diff: extras/rya.pcj.fluo/pcj.fluo.api/src/main/java/org/apache/rya/indexing/pcj/fluo/api/GetQueryReport.java ---
@@ -25,9 +25,9 @@
import java.util.List;
import java.util.Map;
-import javax.annotation.Nullable;
-import javax.annotation.ParametersAreNonnullByDefault;
-import javax.annotation.concurrent.Immutable;
+import edu.umd.cs.findbugs.annotations.Nullable;
--- End diff --
Same
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/115#discussion_r83737780
--- Diff: extras/rya.console/src/main/java/org/apache/rya/shell/SharedShellState.java ---
@@ -23,10 +23,10 @@
import java.util.Objects;
import java.util.concurrent.locks.ReentrantLock;
-import javax.annotation.Nullable;
-import javax.annotation.ParametersAreNonnullByDefault;
-import javax.annotation.concurrent.Immutable;
-import javax.annotation.concurrent.ThreadSafe;
+import edu.umd.cs.findbugs.annotations.Nullable;
--- End diff --
Do you mean the new package name? Yeah, that's intentional but I don't know if it's correct. I was told to use findbug-annotations, and that's where the nullable annotation lives.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/115#discussion_r83735200
--- Diff: extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/query/QueryMetadata.java ---
@@ -20,9 +20,9 @@
import static com.google.common.base.Preconditions.checkNotNull;
-import javax.annotation.Nullable;
-import javax.annotation.ParametersAreNonnullByDefault;
-import javax.annotation.concurrent.Immutable;
+import edu.umd.cs.findbugs.annotations.Nullable;
--- End diff --
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/incubator-rya/pull/115
Not sure about ParametersAreNonNullByDefault, curiously, it's mentioned https://github.com/stephenc/findbugs-annotations/blob/master/src/spec/javadoc/edu/umd/cs/findbugs/annotations/DefaultAnnotationForParameters.html#L87-L91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on the issue:
https://github.com/apache/incubator-rya/pull/115
Just the Nullable annotation. I imagine it has something to do with findbugs, but it seems odd that we would have to use the 3rd party annotation over the java one. I kinda wish we could link the // SEE RYA-211 with an actual javadoc link to jira
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/115#discussion_r83738363
--- Diff: extras/rya.console/src/main/java/org/apache/rya/shell/SharedShellState.java ---
@@ -23,10 +23,10 @@
import java.util.Objects;
import java.util.concurrent.locks.ReentrantLock;
-import javax.annotation.Nullable;
-import javax.annotation.ParametersAreNonnullByDefault;
-import javax.annotation.concurrent.Immutable;
-import javax.annotation.concurrent.ThreadSafe;
+import edu.umd.cs.findbugs.annotations.Nullable;
--- End diff --
if its the correct one then :shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #115: RYA-200 Removing findbugs:jsr305 Dependency
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/115#discussion_r83735246
--- Diff: extras/rya.pcj.fluo/pcj.fluo.client/src/main/java/org/apache/rya/indexing/pcj/fluo/client/PcjAdminClientProperties.java ---
@@ -22,14 +22,14 @@
import java.util.Properties;
-import javax.annotation.Nullable;
-import javax.annotation.ParametersAreNonnullByDefault;
+import edu.umd.cs.findbugs.annotations.Nullable;
--- End diff --
pang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---