You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/07/29 01:53:18 UTC
Review Request 24020: Adjusted the order in which filters are added/removed
to tolerate slave crashes while adding/removing filters.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/
-----------------------------------------------------------
Review request for mesos, Chi Zhang and Ian Downes.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
Diff: https://reviews.apache.org/r/24020/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Jie Yu <yu...@gmail.com>.
> On July 29, 2014, 12:24 a.m., Chi Zhang wrote:
> > I think it is worth mentioning that we are doing this because _recover solely relies on the information on vethX so we want that port ranges on vethX are always more complete than those on eth0 or lo.
> >
> > also don't we need to loosen some checking for the ephemeral port in _recover as well?
Yes. I've updated the review. Please take a close look.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review48946
-----------------------------------------------------------
On July 29, 2014, 5:14 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24020/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 5:14 a.m.)
>
>
> Review request for mesos, Chi Zhang and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
> src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
>
> Diff: https://reviews.apache.org/r/24020/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review48946
-----------------------------------------------------------
I think it is worth mentioning that we are doing this because _recover solely relies on the information on vethX so we want that port ranges on vethX are always more complete than those on eth0 or lo.
also don't we need to loosen some checking for the ephemeral port in _recover as well?
- Chi Zhang
On July 28, 2014, 11:53 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24020/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 11:53 p.m.)
>
>
> Review request for mesos, Chi Zhang and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
> src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
>
> Diff: https://reviews.apache.org/r/24020/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Jie Yu <yu...@gmail.com>.
> On July 29, 2014, 12:55 a.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 2184-2186
> > <https://reviews.apache.org/r/24020/diff/1/?file=643992#file643992line2184>
> >
> > Seems this function is poorly named if it can optionally also remove filters on the veth?
> >
> > Do you need to explicitly remove filters off the veth, or can you just remove the bind mount and have the kernel clean that side up?
> >
> > - okay, I see it's used for update(). Seems to me this is mixing different functionality.
The 'Host' here means the filters are on the host side (versus on the container side).
I am gonna ignore this comment for now. We can revisit that later.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review48952
-----------------------------------------------------------
On July 28, 2014, 11:53 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24020/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 11:53 p.m.)
>
>
> Review request for mesos, Chi Zhang and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
> src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
>
> Diff: https://reviews.apache.org/r/24020/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review48952
-----------------------------------------------------------
Ship it!
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85781>
automatically removed by the kernel?
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85782>
s/slave can crash/slave could crash/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85787>
Seems this function is poorly named if it can optionally also remove filters on the veth?
Do you need to explicitly remove filters off the veth, or can you just remove the bind mount and have the kernel clean that side up?
- okay, I see it's used for update(). Seems to me this is mixing different functionality.
- Ian Downes
On July 28, 2014, 4:53 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24020/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 4:53 p.m.)
>
>
> Review request for mesos, Chi Zhang and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
> src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
>
> Diff: https://reviews.apache.org/r/24020/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Jie Yu <yu...@gmail.com>.
> On July 29, 2014, 6:25 p.m., Chi Zhang wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1908
> > <https://reviews.apache.org/r/24020/diff/1-2/?file=643992#file643992line1908>
> >
> > I agree that this flags isn't very Cpp style.
> >
> > Shouldn't be hard to break it up into two routines? one operates on eth0 and lo, the other vethX. 'update' calls both; 'cleanup' calls one? But I will leave it to you.
Yeah, i still prefer the existing way.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review49001
-----------------------------------------------------------
On July 29, 2014, 5:44 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24020/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 5:44 a.m.)
>
>
> Review request for mesos, Chi Zhang and Ian Downes.
>
>
> Bugs: MESOS-1649
> https://issues.apache.org/jira/browse/MESOS-1649
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
> src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
>
> Diff: https://reviews.apache.org/r/24020/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Chi Zhang <ch...@gmail.com>.
> On July 29, 2014, 6:25 p.m., Chi Zhang wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1193
> > <https://reviews.apache.org/r/24020/diff/1-2/?file=643992#file643992line1193>
> >
> > Maybe add a comment here: that we only look at vethX for port ranges during recovery, that's why we add filters to vethX before eth0 and lo, and filter from eth0 and lo from vethX.
"and remove filters from eth0 and lo before vethX."
- Chi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review49001
-----------------------------------------------------------
On July 29, 2014, 5:44 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24020/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 5:44 a.m.)
>
>
> Review request for mesos, Chi Zhang and Ian Downes.
>
>
> Bugs: MESOS-1649
> https://issues.apache.org/jira/browse/MESOS-1649
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
> src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
>
> Diff: https://reviews.apache.org/r/24020/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review49001
-----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85828>
let's leave a comment on local variable 'pids', to be explicit that the pids are from the device names.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85838>
Maybe add a comment here: that we only look at vethX for port ranges during recovery, that's why we add filters to vethX before eth0 and lo, and filter from eth0 and lo from vethX.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85834>
s/likely/possible/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85836>
I agree that this flags isn't very Cpp style.
Shouldn't be hard to break it up into two routines? one operates on eth0 and lo, the other vethX. 'update' calls both; 'cleanup' calls one? But I will leave it to you.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85837>
s/is used later/is used again/
typo from me. :)
- Chi Zhang
On July 29, 2014, 5:44 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24020/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 5:44 a.m.)
>
>
> Review request for mesos, Chi Zhang and Ian Downes.
>
>
> Bugs: MESOS-1649
> https://issues.apache.org/jira/browse/MESOS-1649
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
> src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
>
> Diff: https://reviews.apache.org/r/24020/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review49180
-----------------------------------------------------------
Ship it!
Ship It!
- Ian Downes
On July 29, 2014, 6:23 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24020/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 6:23 p.m.)
>
>
> Review request for mesos, Chi Zhang and Ian Downes.
>
>
> Bugs: MESOS-1649
> https://issues.apache.org/jira/browse/MESOS-1649
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
> src/slave/containerizer/isolators/network/port_mapping.cpp 4dfaeef
>
> Diff: https://reviews.apache.org/r/24020/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review49136
-----------------------------------------------------------
Ship it!
Ship It!
- Chi Zhang
On July 30, 2014, 1:23 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24020/
> -----------------------------------------------------------
>
> (Updated July 30, 2014, 1:23 a.m.)
>
>
> Review request for mesos, Chi Zhang and Ian Downes.
>
>
> Bugs: MESOS-1649
> https://issues.apache.org/jira/browse/MESOS-1649
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
> src/slave/containerizer/isolators/network/port_mapping.cpp 4dfaeef
>
> Diff: https://reviews.apache.org/r/24020/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/
-----------------------------------------------------------
(Updated July 30, 2014, 1:23 a.m.)
Review request for mesos, Chi Zhang and Ian Downes.
Changes
-------
Review comments.
Bugs: MESOS-1649
https://issues.apache.org/jira/browse/MESOS-1649
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
src/slave/containerizer/isolators/network/port_mapping.cpp 4dfaeef
Diff: https://reviews.apache.org/r/24020/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Jie Yu <yu...@gmail.com>.
> On July 29, 2014, 6:10 p.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1918-1920
> > <https://reviews.apache.org/r/24020/diff/1-2/?file=643992#file643992line1918>
> >
> > Why not have deallocate() just return if passed an empty interval?
>
> Jie Yu wrote:
> We have some sanity check inside deallocate(). Yeah, I can do this check inside allocator.
I'll just drop this to make the allocator logic simple.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review48999
-----------------------------------------------------------
On July 29, 2014, 5:44 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24020/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 5:44 a.m.)
>
>
> Review request for mesos, Chi Zhang and Ian Downes.
>
>
> Bugs: MESOS-1649
> https://issues.apache.org/jira/browse/MESOS-1649
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
> src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
>
> Diff: https://reviews.apache.org/r/24020/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Jie Yu <yu...@gmail.com>.
> On July 29, 2014, 6:10 p.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1105-1108
> > <https://reviews.apache.org/r/24020/diff/1-2/?file=643992#file643992line1105>
> >
> > The sentinel file is the bind mount which keeps the namespace active? Do we not guarantee the bind mount is present if the forked executor has been signaled to exec? If so, then I don't understand how case 2 can occur.
No, the sentinel file is the file that slave write to the meta to indicate an executor has been destroyed.
> On July 29, 2014, 6:10 p.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1918-1920
> > <https://reviews.apache.org/r/24020/diff/1-2/?file=643992#file643992line1918>
> >
> > Why not have deallocate() just return if passed an empty interval?
We have some sanity check inside deallocate(). Yeah, I can do this check inside allocator.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review48999
-----------------------------------------------------------
On July 29, 2014, 5:44 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24020/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 5:44 a.m.)
>
>
> Review request for mesos, Chi Zhang and Ian Downes.
>
>
> Bugs: MESOS-1649
> https://issues.apache.org/jira/browse/MESOS-1649
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
> src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
>
> Diff: https://reviews.apache.org/r/24020/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review48999
-----------------------------------------------------------
A few questions around my understanding that I'd like to clarify before "ship it".
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85822>
The sentinel file is the bind mount which keeps the namespace active? Do we not guarantee the bind mount is present if the forked executor has been signaled to exec? If so, then I don't understand how case 2 can occur.
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85823>
s/cleanup/clean up/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85824>
s/let 'cleanup' function to clean it up later/let the 'cleanup' function clean it up later/
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85825>
Why not have deallocate() just return if passed an empty interval?
src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/24020/#comment85826>
But it still appends an error such that this function returns Error? My interpretation of the comment is that a failed rm would be ignored.
- Ian Downes
On July 28, 2014, 10:44 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24020/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 10:44 p.m.)
>
>
> Review request for mesos, Chi Zhang and Ian Downes.
>
>
> Bugs: MESOS-1649
> https://issues.apache.org/jira/browse/MESOS-1649
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
> src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
>
> Diff: https://reviews.apache.org/r/24020/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/
-----------------------------------------------------------
(Updated July 29, 2014, 5:44 a.m.)
Review request for mesos, Chi Zhang and Ian Downes.
Changes
-------
Updated "Bugs".
Bugs: MESOS-1649
https://issues.apache.org/jira/browse/MESOS-1649
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
Diff: https://reviews.apache.org/r/24020/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 24020: Adjusted the order in which filters are
added/removed to tolerate slave crashes while adding/removing filters.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/
-----------------------------------------------------------
(Updated July 29, 2014, 5:14 a.m.)
Review request for mesos, Chi Zhang and Ian Downes.
Changes
-------
Please take a close look again. I've changed the _recover a little bit to deal with slave crashes while calling isolate().
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.hpp dd1db7f
src/slave/containerizer/isolators/network/port_mapping.cpp 5645e20
Diff: https://reviews.apache.org/r/24020/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu