You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2009/03/13 09:22:50 UTC

[jira] Created: (HAMA-172) Vector.add(Vector v) should throw the Index out of bounds exception when they are different

Vector.add(Vector v) should throw the Index out of bounds exception when they are different
-------------------------------------------------------------------------------------------

                 Key: HAMA-172
                 URL: https://issues.apache.org/jira/browse/HAMA-172
             Project: Hama
          Issue Type: Bug
          Components: implementation
    Affects Versions: 0.1.0
            Reporter: Edward J. Yoon
            Assignee: Edward J. Yoon
             Fix For: 0.1.0


Vector.add(Vector v) should throw the Index out of bounds exception when they are different.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-172) Vector.add(Vector v) should throw the Index out of bounds exception when they are different

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681666#action_12681666 ] 

Hudson commented on HAMA-172:
-----------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12402125/HAMA-172.patch
against trunk revision 752818.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 3 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/166/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/166/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/166/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/166/console

This message is automatically generated.

> Vector.add(Vector v) should throw the Index out of bounds exception when they are different
> -------------------------------------------------------------------------------------------
>
>                 Key: HAMA-172
>                 URL: https://issues.apache.org/jira/browse/HAMA-172
>             Project: Hama
>          Issue Type: Bug
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-172.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Vector.add(Vector v) should throw the Index out of bounds exception when they are different.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-172) Vector.add(Vector v) should throw the Index out of bounds exception when they are different

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681641#action_12681641 ] 

Edward J. Yoon commented on HAMA-172:
-------------------------------------

Below list also should be fixed.

- dot(Vector)
- add(double, Vector)
- set(double, Vector)

> Vector.add(Vector v) should throw the Index out of bounds exception when they are different
> -------------------------------------------------------------------------------------------
>
>                 Key: HAMA-172
>                 URL: https://issues.apache.org/jira/browse/HAMA-172
>             Project: Hama
>          Issue Type: Bug
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Vector.add(Vector v) should throw the Index out of bounds exception when they are different.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-172) Vector.add(Vector v) should throw the Index out of bounds exception when they are different

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-172:
--------------------------------

    Status: Patch Available  (was: Open)

> Vector.add(Vector v) should throw the Index out of bounds exception when they are different
> -------------------------------------------------------------------------------------------
>
>                 Key: HAMA-172
>                 URL: https://issues.apache.org/jira/browse/HAMA-172
>             Project: Hama
>          Issue Type: Bug
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-172.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Vector.add(Vector v) should throw the Index out of bounds exception when they are different.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-172) Vector.add(Vector v) should throw the Index out of bounds exception when they are different

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-172:
--------------------------------

    Attachment: HAMA-172.patch

I made a checkComformantSize(Vector v2).

> Vector.add(Vector v) should throw the Index out of bounds exception when they are different
> -------------------------------------------------------------------------------------------
>
>                 Key: HAMA-172
>                 URL: https://issues.apache.org/jira/browse/HAMA-172
>             Project: Hama
>          Issue Type: Bug
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-172.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Vector.add(Vector v) should throw the Index out of bounds exception when they are different.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-172) Vector.add(Vector v) should throw the Index out of bounds exception when they are different

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681660#action_12681660 ] 

Edward J. Yoon commented on HAMA-172:
-------------------------------------

Local test passed. Submit my patch.

> Vector.add(Vector v) should throw the Index out of bounds exception when they are different
> -------------------------------------------------------------------------------------------
>
>                 Key: HAMA-172
>                 URL: https://issues.apache.org/jira/browse/HAMA-172
>             Project: Hama
>          Issue Type: Bug
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-172.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Vector.add(Vector v) should throw the Index out of bounds exception when they are different.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-172) Vector.add(Vector v) should throw the Index out of bounds exception when they are different

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-172:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this.

> Vector.add(Vector v) should throw the Index out of bounds exception when they are different
> -------------------------------------------------------------------------------------------
>
>                 Key: HAMA-172
>                 URL: https://issues.apache.org/jira/browse/HAMA-172
>             Project: Hama
>          Issue Type: Bug
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-172.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Vector.add(Vector v) should throw the Index out of bounds exception when they are different.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.