[GitHub] [incubator-shardingsphere] SteNicholas commented on a change in pull request #3820: use utf8 charset.

[GitBox <gi...@apache.org>]

SteNicholas commented on a change in pull request #3820: use utf8 charset.
URL: https://github.com/apache/incubator-shardingsphere/pull/3820#discussion_r361588420
 
 

 ##########
 File path: sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/encrypt/impl/AESShardingEncryptor.java
 ##########
 @@ -71,7 +71,7 @@ public Object decrypt(final String ciphertext) {
             return null;
         }
         byte[] result = getCipher(Cipher.DECRYPT_MODE).doFinal(Base64.decodeBase64(String.valueOf(ciphertext)));
-        return new String(result, Charsets.UTF_8);
+        return new String(result, StandardCharsets.UTF_8);
 
 Review comment:
   Why use `java.nio.charset.StandardCharsets`  not `org.apache.commons.codec.Charsets`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services