You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/09/24 14:44:04 UTC

[GitHub] [jackrabbit-filevault] reschke commented on a diff in pull request #245: JCRVLT-658: Importer fails for invalid namespace names

reschke commented on code in PR #245:
URL: https://github.com/apache/jackrabbit-filevault/pull/245#discussion_r979257377


##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java:
##########
@@ -1200,28 +1200,37 @@ private boolean isPropertyProtected(@NotNull EffectiveNodeType effectiveNodeType
         return effectiveNodeType.getApplicablePropertyDefinition(npResolver.getJCRName(docViewProperty.getName()), docViewProperty.isMultiValue(), docViewProperty.getType()).map(PropertyDefinition::isProtected).orElse(false);
     }
 
+    private String nameToPathComponent(Name name) throws RepositoryException {

Review Comment:
   sounds right to me
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org