Re: svn commit: rev 5793 - trunk/tools/client-side

[Kalle Olavi Niemitalo <ko...@iki.fi>]

rooneg@tigris.org writes:

> +(defun vc-svn-find-version (file rev buffer)
> +  (apply 'vc-do-command buffer 0 vc-svn-program-name file 
> +         "cat" (list "-r" rev)))

That can be simplified to:

(defun vc-svn-find-version (file rev buffer)
  (vc-do-command buffer 0 vc-svn-program-name file
                 "cat" "-r" rev))

which is consistent with the rest of vc-svn.el.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 5793 - trunk/tools/client-side

[Garrett Rooney <ro...@electricjellyfish.net>]

On Sunday, May 4, 2003, at 09:07 AM, Kalle Olavi Niemitalo wrote:

> rooneg@tigris.org writes:
>
>> +(defun vc-svn-find-version (file rev buffer)
>> +  (apply 'vc-do-command buffer 0 vc-svn-program-name file
>> +         "cat" (list "-r" rev)))
>
> That can be simplified to:
>
> (defun vc-svn-find-version (file rev buffer)
>   (vc-do-command buffer 0 vc-svn-program-name file
>                  "cat" "-r" rev))
>
> which is consistent with the rest of vc-svn.el.

that makes sense, i'll change it now.  my version was based on 
vc-cvs.el, which is where the apply came from, but if we can do without 
it (and be more consistent) i'm all for it.  honestly, my lisp-fu is 
quite minimal, so while i suspected something like that would be 
possible, i wasn't sure.

thanks for the review.

-garrett


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org