[GitHub] sijie commented on issue #1941: (WIP) Exclude defaultrack bookies when enforceMinNumRacksPerWriteQuorum is enabled

[GitBox <gi...@apache.org>]

sijie commented on issue #1941: (WIP) Exclude defaultrack bookies when enforceMinNumRacksPerWriteQuorum is enabled
URL: https://github.com/apache/bookkeeper/pull/1941#issuecomment-463020584
 
 
   > 1. what should be the name of the metric for this stat?
   
   I am thinking of `placementpolicy/<rack>/num_writable_bookie`.
   
   > 1. If that is the case how can we create actionable alerts without knowing name of the metric/stats upfront?
   
   different metrics/altering system might have different behaviors. some of the alerting systems are allowed '*' queries. so you can write alert rules on using `placementpolicy/*/num_writable_bookie` (e.g. count("placementpolicy/*/num_writble_bookies") => return the number of racks)
   
   > 2\. I can see it might serve as info. purpose
   
   I agree with this. 
   
   > 3\. In any case, even if we decide to have such metrics, I feel it should be treated as a separate work item.
   
   agree
   
   > 3\. Because it needs new code to maintain the specific rack details and corresponding stats/metrics (dynamic in nature).
   
   in current stats library, you can use `scope("rack")` for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services