[GitHub] [netbeans] MegJayan commented on a diff in pull request #4533: Implementation of auto completion, formatting adjustment and providing hints for JEP 405 record patterns

[GitBox <gi...@apache.org>]

MegJayan commented on code in PR #4533:
URL: https://github.com/apache/netbeans/pull/4533#discussion_r975203297


##########
java/java.source.base/src/org/netbeans/modules/java/source/TreeShims.java:
##########
@@ -60,6 +63,8 @@ public class TreeShims {
 //    public static final String NULL_LITERAL = "NULL_LITERAL"; //NOI18N
 //    public static final String PARENTHESIZED_PATTERN = "PARENTHESIZED_PATTERN"; //NOI18N
 //    public static final String GUARDED_PATTERN = "GUARDED_PATTERN"; //NOI18N
+    public static final String DECONSTRUCTION_PATTERN = "DECONSTRUCTION_PATTERN";

Review Comment:
   > Please note that after #4467, it should be possible to refer to the deconstruction/record patterns directly, without the need for reflection and `TreeShims`.
   
   Hi, yes. Have noticed that. Will commit the latest code in some time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists