You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by yu...@apache.org on 2023/02/16 02:40:01 UTC

[spark] branch master updated: [SPARK-42451][SQL][TESTS] Simplifies the filter conditions of `testingVersions` in `HiveExternalCatalogVersionsSuite`

This is an automated email from the ASF dual-hosted git repository.

yumwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 51826647274 [SPARK-42451][SQL][TESTS] Simplifies the filter conditions of `testingVersions` in `HiveExternalCatalogVersionsSuite`
51826647274 is described below

commit 51826647274f161527cf6d0c2ddd59591e8696ab
Author: yangjie01 <ya...@baidu.com>
AuthorDate: Thu Feb 16 10:39:44 2023 +0800

    [SPARK-42451][SQL][TESTS] Simplifies the filter conditions of `testingVersions` in `HiveExternalCatalogVersionsSuite`
    
    ### What changes were proposed in this pull request?
    Spark 3.1.x already EOL and has been deleted from https://dist.apache.org/repos/dist/release/spark, this pr remove the filter condition `!(v.startsWith("3.1") && SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_17))`  from `testingVersions` check, all version already support test with Java 17.
    
    ### Why are the changes needed?
    Delete unnecessary test conditions.
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    Pass GitHub Actions
    
    Closes #40039 from LuciferYang/HiveExternalCatalogVersionsSuite-testVersion.
    
    Authored-by: yangjie01 <ya...@baidu.com>
    Signed-off-by: Yuming Wang <yu...@ebay.com>
---
 .../org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala  | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
index a9d38cecc78..c0abb93ce0c 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
@@ -262,7 +262,7 @@ object PROCESS_TABLES extends QueryTest with SQLTestUtils {
   // Tests the latest version of every release line.
   val testingVersions: Seq[String] = if (isPythonVersionAvailable) {
     import scala.io.Source
-    val versions: Seq[String] = try Utils.tryWithResource(
+    try Utils.tryWithResource(
       Source.fromURL(s"$releaseMirror/spark")) { source =>
       source.mkString
         .split("\n")
@@ -274,8 +274,6 @@ object PROCESS_TABLES extends QueryTest with SQLTestUtils {
       // Do not throw exception during object initialization.
       case NonFatal(_) => Nil
     }
-    versions.filter(v => !(v.startsWith("3.1") &&
-      SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_17)))
   } else Seq.empty[String]
 
   protected var spark: SparkSession = _


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org