You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bval.apache.org by GitBox <gi...@apache.org> on 2020/09/22 13:49:27 UTC
[GitHub] [bval] jeanouii opened a new pull request #8: BVAL-183 Avoid memory leaks in child (ValueExtractors)
jeanouii opened a new pull request #8:
URL: https://github.com/apache/bval/pull/8
Avoid non needed work when no validation constraints are found
Small micro-benchmarks
Fix Java 11 compilation with Java FX as an external library
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bval] rmannibucau merged pull request #8: BVAL-183 Avoid memory leaks in child (ValueExtractors)
Posted by GitBox <gi...@apache.org>.
rmannibucau merged pull request #8:
URL: https://github.com/apache/bval/pull/8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bval] jeanouii commented on pull request #8: BVAL-183 Avoid memory leaks in child (ValueExtractors)
Posted by GitBox <gi...@apache.org>.
jeanouii commented on pull request #8:
URL: https://github.com/apache/bval/pull/8#issuecomment-700499086
If that is all ok, can we get this merged and release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bval] rmannibucau commented on a change in pull request #8: BVAL-183 Avoid memory leaks in child (ValueExtractors)
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on a change in pull request #8:
URL: https://github.com/apache/bval/pull/8#discussion_r492771071
##########
File path: bval-jsr/pom.xml
##########
@@ -262,6 +267,28 @@
<version>2.2.7</version>
<scope>test</scope>
</dependency>
+
Review comment:
some scopes to fix and maybe activation to put in provided, rest is good for me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bval] rmannibucau commented on a change in pull request #8: BVAL-183 Avoid memory leaks in child (ValueExtractors)
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on a change in pull request #8:
URL: https://github.com/apache/bval/pull/8#discussion_r492771071
##########
File path: bval-jsr/pom.xml
##########
@@ -262,6 +267,28 @@
<version>2.2.7</version>
<scope>test</scope>
</dependency>
+
Review comment:
some scopes to fix and maybe activation to put in provided, rest is good for me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bval] jeanouii commented on pull request #8: BVAL-183 Avoid memory leaks in child (ValueExtractors)
Posted by GitBox <gi...@apache.org>.
jeanouii commented on pull request #8:
URL: https://github.com/apache/bval/pull/8#issuecomment-697238129
Thanks for the quick review Romain.
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org