[GitHub] [iotdb] wangchao316 commented on a diff in pull request #10900: [To rel/1.2] fix wal npe when memTable has flushed.

["wangchao316 (via GitHub)" <gi...@apache.org>]

wangchao316 commented on code in PR #10900:
URL: https://github.com/apache/iotdb/pull/10900#discussion_r1299511765


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNode.java:
##########
@@ -457,8 +455,8 @@ private void snapshotMemTable(DataRegion dataRegion, File tsFile, MemTableInfo m
           "CheckpointManager$DeleteOutdatedFileTask.snapshotOrFlushOldestMemTable");
       try {
         // make sure snapshot is made before memTable flush operation
-        synchronized (memTable) {
-          if (memTable.getFlushStatus() != FlushStatus.WORKING) {
+        synchronized (this) {

Review Comment:
   sync this class, Does the WAL write performance be affected?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org