You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/28 15:31:43 UTC

[GitHub] [cloudstack] JoaoJandre commented on pull request #6772: Fix to make recovered volumes be accounted for by Usage

JoaoJandre commented on PR #6772:
URL: https://github.com/apache/cloudstack/pull/6772#issuecomment-1261088013

   > @JoaoJandre did you look at the flow for `changeOfferingForVolume`, `migrateVolume`, `resizeVolume` and `updateVolume`? Not sure but the code you extracted may be used there as well. Please check, CLGTM otherwise.
   
   @DaanHoogland I checked these flows and the event publishes in these places are a bit different, the ones I saw at least already had the `diskOfferingVO` available, so if we used the new method I extracted we would be making an unnecessary call to the DB.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org