[GitHub] [druid] gianm commented on a change in pull request #9279: Guicify druid sql module

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #9279: Guicify druid sql module
URL: https://github.com/apache/druid/pull/9279#discussion_r372166465
 
 

 ##########
 File path: sql/src/main/java/org/apache/druid/sql/guice/SqlModule.java
 ##########
 @@ -63,25 +55,21 @@ public void configure(Binder binder)
     if (isEnabled()) {
       Calcites.setSystemProperties();
 
-      JsonConfigProvider.bind(binder, "druid.sql.planner", PlannerConfig.class);
-      JsonConfigProvider.bind(binder, "druid.sql.avatica", AvaticaServerConfig.class);
-      LifecycleModule.register(binder, DruidSchema.class);
       binder.bind(ViewManager.class).to(NoopViewManager.class).in(LazySingleton.class);
 
-      // Add empty SqlAggregator binder.
-      Multibinder.newSetBinder(binder, SqlAggregator.class);
+      binder.install(new DruidCalciteSchemaModule());
 
 Review comment:
   I'm wondering why you wanted to split these up? It seemed nice to me to have all the core SQL-related bindings in one file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org