You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/04 17:33:01 UTC
[GitHub] [airflow] jaketf opened a new pull request #10728: Add note on GKE metadata server Workload Identity
jaketf opened a new pull request #10728:
URL: https://github.com/apache/airflow/pull/10728
Workload Identity is the recommended way of managing authorization to GCP services from GKE.
While it is notably not used by Cloud Composer, I think a note like this could be useful for those who run airflow on GKE themselves, especially those interested in multi-tenancy :)
cc: @mik-laj @potiuk
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10728: Add note on GKE metadata server Workload Identity
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10728:
URL: https://github.com/apache/airflow/pull/10728#discussion_r483852840
##########
File path: docs/howto/connection/gcp.rst
##########
@@ -32,7 +32,13 @@ There are three ways to connect to Google Cloud using Airflow.
1. Use `Application Default Credentials
<https://google-auth.readthedocs.io/en/latest/reference/google.auth.html#google.auth.default>`_,
- such as via the metadata server when running on Google Compute Engine.
+ such as via the metadata server when running on Google Compute Engine or the GKE metadata server
Review comment:
Can you move it to a separate section or paragraph below the text? I think this will make it easier to understand this list and its purpose. If we have a one-line explanation, we can put it in place, but explanations on many lines should be clearly separated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryw commented on pull request #10728: Add note on GKE metadata server Workload Identity
Posted by GitBox <gi...@apache.org>.
ryw commented on pull request #10728:
URL: https://github.com/apache/airflow/pull/10728#issuecomment-717581226
@jaketf would you read @mik-laj review and refresh this PR so we can merge it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jaketf commented on pull request #10728: Add note on GKE metadata server Workload Identity
Posted by GitBox <gi...@apache.org>.
jaketf commented on pull request #10728:
URL: https://github.com/apache/airflow/pull/10728#issuecomment-717625851
Just made the requested changes.
@mik-laj PTAL when you get a chance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #10728: Add note on GKE metadata server Workload Identity
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #10728:
URL: https://github.com/apache/airflow/pull/10728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org