You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/10/26 06:20:55 UTC

[GitHub] [rocketmq-externals] zhangjidi2016 opened a new pull request #642: Filter system topic while console dashboard was making topic statistics

zhangjidi2016 opened a new pull request #642:
URL: https://github.com/apache/rocketmq-externals/pull/642


   ## What is the purpose of the change
   
   Filter system topic while console dashboard was making topic statistics.
   
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] vongosling merged pull request #642: [ISSUE #665] Filter system topic while console dashboard was making topic statistics

Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #642:
URL: https://github.com/apache/rocketmq-externals/pull/642


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] zhangjidi2016 commented on pull request #642: [ISSUE #665] Filter system topic while console dashboard was making topic statistics

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on pull request #642:
URL: https://github.com/apache/rocketmq-externals/pull/642#issuecomment-756502685


   ok，I will make an issue for this pr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] vongosling edited a comment on pull request #642: Filter system topic while console dashboard was making topic statistics

Posted by GitBox <gi...@apache.org>.
vongosling edited a comment on pull request #642:
URL: https://github.com/apache/rocketmq-externals/pull/642#issuecomment-732835347


   You should make an issue as pr template said.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] vongosling commented on pull request #642: Filter system topic while console dashboard was making topic statistics

Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #642:
URL: https://github.com/apache/rocketmq-externals/pull/642#issuecomment-732835347


   You should make an issue as pr template


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-externals] vongosling commented on pull request #642: Filter system topic while console dashboard was making topic statistics

Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #642:
URL: https://github.com/apache/rocketmq-externals/pull/642#issuecomment-740471732


   @zhangjidi2016 ping


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org