You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/19 06:49:59 UTC

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1256: [KYUUBI #1252] Move KyuubiConf#toSparkPrefixedConf out of kyuubi-common module

yaooqinn commented on a change in pull request #1256:
URL: https://github.com/apache/incubator-kyuubi/pull/1256#discussion_r731544744



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
##########
@@ -123,7 +124,7 @@ class SparkProcessBuilder(
     buffer += executable
     buffer += CLASS
     buffer += mainClass
-    conf.toSparkPrefixedConf.foreach { case (k, v) =>
+    getSparkPrefixedConf.foreach { case (k, v) =>

Review comment:
       maybe we can combine map& foreach to a single loop




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org